Closed
Bug 340509
Opened 19 years ago
Closed 19 years ago
Build broken with --enable-ldap-experimental
Categories
(Directory :: LDAP XPCOM SDK, defect)
Directory
LDAP XPCOM SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alfred.peng, Assigned: dmosedale)
References
Details
Attachments
(1 file)
(deleted),
patch
|
darin.moz
:
review+
dmosedale
:
superreview+
|
Details | Diff | Splinter Review |
After adding the --enable-ldap option to configure, the following build errors show up:
"../../../../../directory/xpcom/base/src/nsLDAPChannel.cpp", line 435: Error: NS_UI_THREAD_EVENTQ is not defined.
"../../../../../directory/xpcom/base/src/nsLDAPChannel.cpp", line 437: Error: PROXY_SYNC is not defined.
"../../../../../directory/xpcom/base/src/nsLDAPChannel.cpp", line 437: Error: PROXY_ALWAYS is not defined.
"../../../../../directory/xpcom/base/src/nsLDAPChannel.cpp", line 503: Error: NS_UI_THREAD_EVENTQ is not defined.
"../../../../../directory/xpcom/base/src/nsLDAPChannel.cpp", line 506: Error: PROXY_ASYNC is not defined.
"../../../../../directory/xpcom/base/src/nsLDAPChannel.cpp", line 506: Error: PROXY_ALWAYS is not defined.
"../../../../../directory/xpcom/base/src/nsLDAPChannel.cpp", line 630: Error: NS_UI_THREAD_EVENTQ is not defined.
7 Error(s) detected.
It seems that the bug is related to 326273.
Reporter | ||
Comment 1•19 years ago
|
||
Change according to the nsIThreadManager landing.
Attachment #224541 -
Flags: review?(dmose)
Reporter | ||
Comment 2•19 years ago
|
||
Comment on attachment 224541 [details] [diff] [review]
Patch v1
darin, this bug is related to bug 326273. Could you help me review it?
Attachment #224541 -
Flags: superreview?(dmose)
Attachment #224541 -
Flags: review?(dmose)
Attachment #224541 -
Flags: review?(darin)
Updated•19 years ago
|
Blocks: nsIThreadManager
Updated•19 years ago
|
Attachment #224541 -
Flags: review?(darin) → review+
Comment 3•19 years ago
|
||
doesn't seem solaris specific, fixing summary
OS: SunOS → All
Hardware: PC → All
Summary: Build broken on Solaris in directory/xpcom → Build broken with --enable-ldap-experimental
Assignee | ||
Updated•19 years ago
|
Attachment #224541 -
Flags: superreview?(dmose) → superreview+
Checking in directory/xpcom/base/src/nsLDAPChannel.cpp;
/cvsroot/mozilla/directory/xpcom/base/src/nsLDAPChannel.cpp,v <-- nsLDAPChannel.cpp
new revision: 1.62; previous revision: 1.61
done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•