Closed Bug 340827 Opened 18 years ago Closed 18 years ago

New ATK: Implement nsIAccessibleTable for all nsHTMLTableAccesible

Categories

(Core :: Disability Access APIs, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: gaomingcn)

References

Details

(Keywords: access)

Attachments

(2 files)

Remove the atk/nsHTMLTableAccessibleWrap code and move it to html/nsHTMLTableAccessible where all platforms can benefit from nsIAccessibleTable.
Summary: Implement nsIAccessibleTable for all nsHTMLTableAccesible → New ATK: Implement nsIAccessibleTable for all nsHTMLTableAccesible
Assignee: aaronleventhal → ginn.chen
Assignee: ginn.chen → gaomingcn
Will we remove all the codes in atk/nsHTMLTableAccessibleWrap.cpp and .h and remove the files also? I did so and is testing the code.
(In reply to comment #1) > Will we remove all the codes in atk/nsHTMLTableAccessibleWrap.cpp and .h and > remove the files also? Those files will go away, and the code will move into the html directory as part of the nsHTMLTableAccssible class which already exists. The Wrap class will no longer be necessary.
I kept the wrap class just now. Will change the code again. how about class nsHTMLTableCellAccessibleWrap and nsHTMLTableHeadAccessible? remove nsHTMLTableCellAccessibleWrap and use nsHTMLTableCellAccessible instead when we need it? nsHTMLTableHeadAccessible has many methods defined, should we keep this class?
(In reply to comment #3) > I kept the wrap class just now. Will change the code again. > > how about class nsHTMLTableCellAccessibleWrap and nsHTMLTableHeadAccessible? > remove nsHTMLTableCellAccessibleWrap and use nsHTMLTableCellAccessible instead > when we need it? nsHTMLTableHeadAccessible has many methods defined, should we > keep this class? > We don't want any of the table-related Wrap classes anymore. All of the code should move to cross-platform classes. If there is already a cross platform class for that kind of table element, then merge the code. If there isn't a cross platform class then just move the class into the html directory but make sure it doesn't have "Wrap" in the name. The idea is that we're going to use all of this stuff for all platforms, not just ATK. Originally we had it in Wrap classes in ATK because we only needed it there.
Status: NEW → ASSIGNED
Attached patch patch of this bug. (deleted) — Splinter Review
Attachment #227211 - Flags: review?(aaronleventhal)
Attachment #227213 - Flags: review?(aaronleventhal)
Attachment #227213 - Flags: review?(aaronleventhal) → review+
Comment on attachment 227211 [details] [diff] [review] patch of this bug. I added some tweaks to the patch: 1) Make Table accessible inherit from nsAccessibleWrap (it's not a hyper text, it can't have direct text children) 2) Don't create accessibles for thead/tbody/tfoot in ATK. At some point we'll need to create those for nsIAccessible, but trim them out in the final ATK tree.
Attachment #227211 - Flags: review?(aaronleventhal) → review+
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: