Closed
Bug 341180
Opened 18 years ago
Closed 15 years ago
[Mac] Most widgets shouldn't steal focus on click
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 418521
People
(Reporter: hwaara, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Tested on BonEcho a3, Mac OS X 10.4.6 When clicking a button, or popupmenu, the focus should not change to that. On mac, the focus represents the *keyboard* focus. Only a textfield or listbox/tree should receive keyboard focus (aka "first responder" in Cocoa-jargon) when clicked. Clicks on other widgets should not give it keyboard focus.
Reporter | ||
Updated•18 years ago
|
Keywords: access
Summary: [Mac] Most widgets shouldn't receive focus on click → [Mac] Most widgets shouldn't steal focus on click
Reporter | ||
Comment 1•18 years ago
|
||
This patch fixes most of this bug. There's one case where it's not working yet though: if I have a checkbox and a button next to each other, and the checkbox has focus, clicking the button will make the focus ring go away from the checkbox. The button doesn't receive it though. I'll need to find out why the checkbox gets a blur event, even though focus doesn't change (or isn't supposed to, at least).
Reporter | ||
Comment 2•18 years ago
|
||
Another to do is find all instances of trees/textfields and make them focusable.
Reporter | ||
Comment 3•18 years ago
|
||
Actually, thinking about it, IsFocusable() might not be the right/only place to hook into. I'll have to debug it more to see who's really in charge of changing focus on click. If you have any ideas, let me know.
Comment 4•18 years ago
|
||
How about ccing the focus experts?
Comment 5•18 years ago
|
||
Oliver Yeoh has to be included as one of the focus experts now. He's been active and fixed a few tough bugs recently. Also, all focus bugs should be marked as blocking bug 83552, aka "focusnav".
Blocks: focusnav
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•