"10abc" is not found to be invalid if set as the value of a node with type xsd:double

second input should show up as red

The bug here is that the current end pointer check only worked when the first character was invalid. Rather, just check if it's not at the end (null pointer)

Comment on attachment 225767 [details] [diff] [review] le patch >Index: extensions/schema-validation/src/nsSchemaValidatorUtils.cpp >=================================================================== >RCS file: /cvsroot/mozilla/extensions/schema-validation/src/nsSchemaValidatorUtils.cpp,v >retrieving revision 1.15 >diff -1 -0 -u -p -r1.15 nsSchemaValidatorUtils.cpp >--- extensions/schema-validation/src/nsSchemaValidatorUtils.cpp 24 May 2006 06:44:21 -0000 1.15 >+++ extensions/schema-validation/src/nsSchemaValidatorUtils.cpp 15 Jun 2006 20:49:02 -0000 >@@ -118,32 +118,33 @@ nsSchemaValidatorUtils::IsValidSchemaDou > PRBool isValid = PR_TRUE; > > if (*aString == 0) > return PR_FALSE; > > char * pEnd; > double value = PR_strtod(aString, &pEnd); > > // If end pointer hasn't moved, then the string wasn't a > // true double (could be INF, -INF or NaN though) >- if (pEnd == aString) { >+ if (*pEnd != '\0') { > nsCAutoString temp(aString); you need to change the commet above this test with that, r=me

checked into trunk

checked into 1.8.0 branch on 2006/09/21

checked into 1.8 branch on 2006/11/21