Closed
Bug 341711
Opened 18 years ago
Closed 18 years ago
fix offset* properties to use unscrolled positions
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
This is the other half of bug 334765.
|
Assignee | |
Comment 1•18 years ago
|
||
The offsetTop should be constant regardless of the scroll position, but it isn't.
|
|
Assignee | |
Comment 2•18 years ago
|
||
Fixes offset* regression.
Attachment #225835 -
Flags: superreview?(bzbarsky)
Attachment #225835 -
Flags: review?(bzbarsky)
|
||
Comment 3•18 years ago
|
||
is this the right patch? it seems to be for something foreignObject-related.
|
|
Assignee | |
Comment 4•18 years ago
|
||
Comment on attachment 225835 [details] [diff] [review]
fix
oops, wrong patch
Attachment #225835 -
Flags: superreview?(bzbarsky)
Attachment #225835 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 5•18 years ago
|
||
this is the correct patch, sorry.
It's a very simple change :-)
Attachment #225835 -
Attachment is obsolete: true
Attachment #226257 -
Flags: superreview?(bzbarsky)
Attachment #226257 -
Flags: review?(bzbarsky)
|
||
Comment 6•18 years ago
|
||
Comment on attachment 226257 [details] [diff] [review]
correct patch
Looks good
Attachment #226257 -
Flags: superreview?(bzbarsky)
Attachment #226257 -
Flags: superreview+
Attachment #226257 -
Flags: review?(bzbarsky)
Attachment #226257 -
Flags: review+
|
|
Assignee | |
Comment 7•18 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•