Closed Bug 342123 Opened 18 years ago Closed 17 years ago

Abandoned extension: POTO sidebar

Categories

(addons.mozilla.org Graveyard :: Administration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: ecfbugzilla, Unassigned)

References

()

Details

It was reported that POTO sidebar breaks Adblock Plus. I investigated the issue and found out that this extensions does very stupid things trying to rewrite the JavaScript code for all entries in the View/Sidebar menu. There were more similarly bad things in the code like replacing the function toggleSidebar in Firefox. I sent a description of the problems and my suggestions to mail@leon-huang.com on 2006-03-18. I got no response so I published the text of the mail in the corresponsing Mozillazine forum thread: http://forums.mozillazine.org/viewtopic.php?p=2181062#2181062 - still nothing.
Now that we have a sandbox - can that extension be moved there? There has been a new release, judging by release notes it simply bumped maxVersion to support Firefox 2.0. I downloaded it, this extension is still asking for trouble by rewriting oncommand attributes for all sidebars - it removes the last two characters and adds ", true);". Browser's toggleidebar function is replaced by own code (not extended) which is similarly dangerous.
Justin: one last warning shot, as with the bunch you just did?
Assignee: nobody → fligtar
Version: 2.0 → 3.0
Sorry - is there a security issue here I'm missing? The extension is compatible with 2.0, has good reviews, gets a decent number of downloads, and wasn't updated so long ago that I'd consider it abandoned.
Assignee: fligtar → nobody
Component: Public Pages → Add-ons
QA Contact: web-ui → add-ons
No security issue there, it just breaks things. Rewriting command handlers of other people's menu items with substring operations (not even regular expressions) is just asking for trouble. No longer breaking Adblock Plus however, so I guess I don't have to care...
Excellent. I'd rather not move something that actually has positive reviews back to the sandbox unless it has some serious problems.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
Guess we use very different definitions of "serious problems"...
Add-on incompatibility isn't really a unique thing, and I agree with Justin that it's not worth punting back to the sandbox on that basis. I'm a little worried about the lack of responsiveness, but not enough so to revert it. I think this state is the best of the available ones, for users and the site. Wish I could make things perfect!
Component: Add-ons → Administration
QA Contact: add-ons → administration
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.