Closed Bug 342261 Opened 19 years ago Closed 16 years ago

[nsIAlertsService] all of notification window should be clickable

Categories

(Toolkit :: XUL Widgets, enhancement)

Product:
Toolkit
Component:
XUL Widgets
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: eyalroz1, Assigned: ventnor.bugzilla)

References

Details

(Keywords: polish)

Attachments

(1 file, 2 obsolete files)

For checkin
(deleted), patch
Details | Diff | Splinter Review
When I want to click the 'downloads complete' message to open the downloads window, I don't want to be bothered to locate the link with my mouse - I want the entire notification window to be clickable to the same effect as the existing link. Better user experience IMHO.
Flags: blocking-firefox2?
Not going to block the release on this.
Flags: blocking-firefox2? → blocking-firefox2-
Keywords: polish
Component: Download Manager → General
Flags: blocking-firefox2-
Product: Firefox → Core
QA Contact: download.manager → general
Summary: all of 'downloads complete' notification window should be clickable → [nsIAlertsService] all of notification window should be clickable
Version: unspecified → Trunk
Component: General → XUL Widgets
Product: Core → Toolkit
QA Contact: general → xul.widgets
Attached patch Patch (obsolete) (deleted) — — Splinter Review
Assignee: nobody → ventnor.bugzilla
Attachment #350404 - Flags: review?(gavin.sharp)
Attachment #350404 - Flags: review?(gavin.sharp) → review+
Keywords: checkin-needed
Whiteboard: [needs landing]
Actually, I think I need to theme the new separate Gnomestripe as well.
Keywords: checkin-needed
Whiteboard: [needs landing]
Attached patch Gnomestripe additional patch (obsolete) (deleted) — — Splinter Review
These add exactly the same changes as the Winstripe theme file. Those changes have already received r+.
Keywords: checkin-needed
Whiteboard: [needs landing]
Oops, good catch. I hadn't realized bug 426714 had landed.
Comment on attachment 350404 [details] [diff] [review] Patch Sorry: { patching file toolkit/themes/winstripe/global/alerts/alert.css Hunk #1 FAILED at 71 1 out of 1 hunks FAILED } NB: And if you could concatenate both patches...
Attachment #350404 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [needs landing]
Attached patch For checkin (deleted) — — Splinter Review
Attachment #351669 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/37e5b45acb44
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [needs landing]
Target Milestone: --- → mozilla1.9.2a1
Blocks: 426713
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: