Closed
Bug 342329
Opened 18 years ago
Closed 15 years ago
Install updates should be disabled if all add-ons have been deselected for update.
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: robert.strong.bugs, Assigned: lusian)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
spinoff from bug 307358. Another option may be to just use the add-ons message notification area - this would be *much* simpler and cleaner.
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
|
||
Updated•16 years ago
|
Whiteboard: [good first bug]
|
Assignee | |
Comment 2•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Attachment #405821 -
Flags: review?(robert.bugzilla)
|
Reporter | |
Updated•15 years ago
|
Attachment #405821 -
Flags: review?(robert.bugzilla) → review?(dtownsend)
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 405821 [details] [diff] [review]
Disable the "Install Updates" button if all add-ons are deselected for update, 0
You shouldn't need to loop through the entire list most of the time. As soon as you find a single checked checkbox you can enable the button at that point and end the loop.
Attachment #405821 -
Flags: review?(dtownsend) → review-
|
|
Assignee | |
Comment 4•15 years ago
|
||
Attachment #405821 -
Attachment is obsolete: true
Attachment #405960 -
Flags: review?(dtownsend)
|
|
||
Updated•15 years ago
|
Attachment #405960 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Updated•15 years ago
|
Attachment #405960 -
Flags: ui-review?(beltzner)
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 405960 [details] [diff] [review]
Disable the "Install Updates" button if all add-ons are deselected for update, 1
This does not need a ui review
Attachment #405960 -
Flags: ui-review?(beltzner)
|
|
Assignee | |
Comment 6•15 years ago
|
||
Somebody push the patch to the trunk, please?
|
|
||
Comment 7•15 years ago
|
||
Pushed to trunk: http://hg.mozilla.org/mozilla-central/rev/8e1ea35b1294
Assignee: nobody → lusian
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•