Closed
Bug 342364
Opened 18 years ago
Closed 18 years ago
don't scroll the tab strip on mouseover (unless we are dragging), make a click be necessary
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 beta1
People
(Reporter: moco, Assigned: moco)
References
Details
(Keywords: fixed1.8.1, Whiteboard: 181b1+)
Attachments
(1 file)
(deleted),
patch
|
bugs
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
should the scrolling tab strip scroll on mouseover, or should click be necessary?
spun off from bug #318168:
a good point from mark (who has a patch to make scrolling work for mac!):
he's wondering why we scroll on mouseover (and not requiring a click, see bug
#342229). excluding the "while dragging" scenario, should we really scroll
automatically on mouseover of the scrollbox buttons like we do in menus? or
should we behave more like a scrollbar.
Assignee | ||
Updated•18 years ago
|
Depends on: tabbedbrowsing
Comment 1•18 years ago
|
||
I haven't played with the scrolling tab strip yet (is it in nightlies?) but having it scroll on mouseover is definitely not the right way to go as the default interaction. It's a pleasant optimization when dragging a tab, but other than that, we should wait for a click.
Assignee | ||
Comment 2•18 years ago
|
||
> I haven't played with the scrolling tab strip yet (is it in nightlies?)
not yet, the patch is awaiting reviews.
> but having it scroll on mouseover is definitely not the right way to go as the
> default interaction.
I agree with you and mark. (Thanks to mento for pointing this out!)
asking for blocking. I hope to fix this before 318168 lands (or immediately after)
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Assignee | ||
Comment 3•18 years ago
|
||
updating summary.
for mouseover on drag, we'll still scroll by [x] pixels at a time (x defaults to 20, but there is a hidden pref to override)
for click, I'll go one tab at a time.
Summary: should the scrolling tab strip scroll on mouseover, or should click be necessary? → don't scroll the tab strip on mouseover (unless we are dragging), make a click be necessary
Assignee | ||
Comment 4•18 years ago
|
||
the fix for this is now part of the fix for bug #318168
the only remaining piece is how to style the arrowscrollbox buttons on hover for both winstripe and pinstripe
Assignee | ||
Comment 5•18 years ago
|
||
this will be fixed when bug #318168 is fixed, but leaving this bug open for future reference since the behavior on mouseover is discussed directly.
Target Milestone: --- → Firefox 2 beta1
Assignee | ||
Comment 6•18 years ago
|
||
this is fixed (on the trunk, at least).
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 7•18 years ago
|
||
Using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060627 Minefield/3.0a1 I don't get the clickable behavior when I use the tab scroll that apparently is supposed to be present. Seth asked me to add my comments and reopen this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 8•18 years ago
|
||
oops, I think I forgot to add the clicktoscroll attribute in the mac specific binding for scrollbox.xml
thanks marcia! on it...
Status: REOPENED → ASSIGNED
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 9•18 years ago
|
||
Attachment #227288 -
Flags: review?(mconnor)
Assignee | ||
Comment 10•18 years ago
|
||
Comment on attachment 227288 [details] [diff] [review]
fix for pinstripe
switching review to ben.
Attachment #227288 -
Flags: review?(mconnor) → review?(bugs)
Comment 11•18 years ago
|
||
Attachment #227288 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 12•18 years ago
|
||
fix checked into the trunk. I'll make a new patch for bug #318168 that includes this change.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago → 18 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Whiteboard: 181b1+
Assignee | ||
Comment 13•18 years ago
|
||
Comment on attachment 227288 [details] [diff] [review]
fix for pinstripe
seeking approval to land this (as well as the patch in bug #318168)
Attachment #227288 -
Flags: approval1.8.1?
Comment 14•18 years ago
|
||
Looks good to me on the Mac using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060628 Minefield/3.0a1. I can now click on the widget to scroll the tab instead of yesterday's behavior when it was auto scrolling on hover.
Comment 15•18 years ago
|
||
Comment on attachment 227288 [details] [diff] [review]
fix for pinstripe
Approving on 1.8.1 branch for 1.8.1 drivers.
Attachment #227288 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 16•18 years ago
|
||
fixed landed on the 1.8 branch.
thanks to marcia for verifying this on the trunk.
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•