Closed
Bug 342365
Opened 18 years ago
Closed 14 years ago
tab drop indicator is cropped by 2 pixels
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: moco, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
image/png
|
Details |
tab drop indicator is cropped by 2 pixels
the drop indicator is really 11 pixels, but we have the box width of the
tab-drop-indicator box as 9 pixels. It's barely noticeable unless you've spent
way too look starring at the drop indicator. I'll attach a zoomed in screen
shot. it should be an easy fix, now that I am using ind.boxObject.width in the
code.
spun off from bug #318168
screen shot coming.
Reporter | ||
Comment 1•18 years ago
|
||
Comment 2•18 years ago
|
||
Hmm, I actually like the cropped image better.
Reporter | ||
Comment 3•18 years ago
|
||
> Hmm, I actually like the cropped image better.
if others agree, we could replace the 11 pixel image with a 9px version.
Status: NEW → ASSIGNED
Comment 4•18 years ago
|
||
Yeah, just make it a 9px image. There's a bunch of stuff we could be doing better to indicate where the tab would go, but I don't know if there's time for it. Off the top of my head:
* extend a line from the tip of the arrow between the two tabs where the dragged tab will be inserted
* don't draw anything when the result will be a no-op (ie: immediately before or after where the tab currently is)
Reporter | ||
Comment 5•18 years ago
|
||
mike, I'll log some spin off bugs on those improvements.
Reporter | ||
Comment 6•17 years ago
|
||
sorry for the bug spam, re-assigning bugs back to default owner if I'm not working actively on them.
Assignee: sspitzer → nobody
Status: ASSIGNED → NEW
Comment 7•17 years ago
|
||
does this also account for it's off-center appearance? I.E. the arrow is not centered in the gap between tabs, rather, it is positioned to the rightmost edge of of the tab to the left.
Severity: normal → trivial
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•