Closed
Bug 342845
Opened 19 years ago
Closed 18 years ago
when dragging a tab over the "all tabs" button, act as if we are dragging over the "scroll down" button
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
VERIFIED
FIXED
Firefox 2 beta2
People
(Reporter: ancestor.ak, Assigned: moco)
References
Details
(Keywords: verified1.8.1)
Attachments
(2 files, 3 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
The scroll box arrows for the tab overflow are quite tiny. If I didn't know what to look for it would probably take me a while to notice them. This is both a discoverability and a usability problem: tabs may seem to disappear for those who don't know about the scrolling, the hit area is very small and it doesn't even extend to the edge of the screen.
Comment 1•19 years ago
|
||
I would also add enough space to open a new tab by double-clicking in the tab bar. Probably a different bug, but, related.
Updated•19 years ago
|
Assignee: nobody → sspitzer
Reporter | ||
Comment 2•19 years ago
|
||
Requesting blocking-firefox2 as I feel this heavily impacts usability of the feature.
Flags: blocking-firefox2?
Comment 3•19 years ago
|
||
This will be addressed by the new theme work, adding blocking beta 2 to keep it on our radar.
Flags: blocking-firefox2? → blocking-firefox2+
Target Milestone: --- → Firefox 2 beta2
Comment 4•19 years ago
|
||
Maybe mousing over one of the arrows should automatically scroll the tab bar in that direction
Comment 5•19 years ago
|
||
The necessary userChrome.css hack, waiting for the theme fix:
autorepeatbutton {
width: 20px !important;
}
Assignee | ||
Comment 6•19 years ago
|
||
with bug #343097, asaf has made it so we're using toolbarbuttons and not autorepeatbuttons, so things will look (and act) accordingly.
Depends on: 343097
Assignee | ||
Comment 7•19 years ago
|
||
Updated•19 years ago
|
Summary: Scrolling arrows on the tab bar are too small and don't extend to the edge of the screen (Fitt's Law) → Scrolling arrows on the tab bar are too small and don't extend to the edge of the screen (Fitts' Law)
Comment 8•18 years ago
|
||
*** Bug 344407 has been marked as a duplicate of this bug. ***
Updated•18 years ago
|
Whiteboard: [to decide once 343251 is landed]
Assignee | ||
Comment 9•18 years ago
|
||
bug #343251 has landed.
Note: about "Scrolling arrows on the tab bar are too small and don't extend to the edge of the screen (Fitts' Law)", the one on the right (or left, for RTL) won't extend to the edge anyways, due to the "all tabs" button.
Status: NEW → ASSIGNED
Comment 10•18 years ago
|
||
The scrollbutton images, regardless, will never actually extend to the end of the tabstrip. However, for the purposes of scrolling when the user is dragging a tab, the target area that activates the scroll should extend all the way to the end of the screen.
Dunno if that's a morph or a new bug.
Comment 11•18 years ago
|
||
Fitts issue could be solved by bug 345884
Assignee | ||
Comment 12•18 years ago
|
||
spoke with mconnor, and then plan for this bug is:
when dragging and dropping tabs, if you are hovering over the "all tabs" button, continue to scroll (as if you were hovering over the scroll button)
working on a fix...
Assignee | ||
Updated•18 years ago
|
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 13•18 years ago
|
||
Attachment #231819 -
Flags: review?(mconnor)
Assignee | ||
Updated•18 years ago
|
Summary: Scrolling arrows on the tab bar are too small and don't extend to the edge of the screen (Fitts' Law) → when dragging a tab over the
Whiteboard: [to decide once 343251 is landed]
Assignee | ||
Comment 14•18 years ago
|
||
morphing bug, but I need to fix my patch.
I need to verify that the scroll button down is not collapsed when doing this.
Summary: when dragging a tab over the → when dragging a tab over the "all tabs" button, act as if we are dragging over the "scroll down" button
Assignee | ||
Updated•18 years ago
|
Attachment #231819 -
Flags: review?(mconnor)
Assignee | ||
Comment 15•18 years ago
|
||
Attachment #231819 -
Attachment is obsolete: true
Attachment #231834 -
Flags: review?(mconnor)
Assignee | ||
Comment 16•18 years ago
|
||
Attachment #231834 -
Attachment is obsolete: true
Attachment #231836 -
Flags: review?(mconnor)
Attachment #231834 -
Flags: review?(mconnor)
Assignee | ||
Comment 17•18 years ago
|
||
Attachment #231836 -
Attachment is obsolete: true
Attachment #231848 -
Flags: review?(mconnor)
Attachment #231836 -
Flags: review?(mconnor)
Assignee | ||
Comment 18•18 years ago
|
||
> I need to verify that the scroll button down is not collapsed when doing this.
the reason for that is so that we don't draw the drop indicator (on the end, near the all tabs button) when dragging a tab and the scroll buttons are collapsed.
the reason for the last version is I forgot a brace in the previous version.
Whiteboard: [seeking review]
Updated•18 years ago
|
Attachment #231848 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 19•18 years ago
|
||
fixed on the trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 20•18 years ago
|
||
Comment on attachment 231848 [details] [diff] [review]
patch
seeking approval for branch
Attachment #231848 -
Flags: approval1.8.1?
Assignee | ||
Updated•18 years ago
|
Whiteboard: [seeking review] → [seeking approval]
Comment 21•18 years ago
|
||
Comment on attachment 231848 [details] [diff] [review]
patch
a=mconnor on behalf of drivers for checkin to 1.8 branch
Attachment #231848 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 22•18 years ago
|
||
fixed on branch.
Keywords: fixed1.8.1
Whiteboard: [seeking approval]
Comment 23•18 years ago
|
||
Verified FIXED using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b1) Gecko/20060805 BonEcho/2.0b1.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•