Closed
Bug 343022
Opened 18 years ago
Closed 18 years ago
Increased Rlk leak on balsa (2006-06-27)
Categories
(Toolkit :: Password Manager, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: ispiked, Unassigned)
References
Details
(Keywords: memory-leak)
Attachments
(1 file, 2 obsolete files)
2560 MOZ_CO_DATE=2006:06:27:17:17:00
2916 MOZ_CO_DATE=2006:06:27:22:01:00
Check-ins:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006%3A06%3A27%3A17%3A17%3A00&maxdate=2006%3A06%3A27%3A22%3A01%3A00&cvsroot=%2Fcvsroot
From the leak log:
nsPasswordManager 152 -
nsPrefBranch 60 -
nsVoidArray 4 -
nsLocalFile 124 -
nsStringBuffer 32 100.00%
CCing folks who made the check-ins.
|
||
Comment 2•18 years ago
|
||
Comment on attachment 227443 [details] [diff] [review]
Release reference to password manager when doing early initialization
> } else if (!strcmp(aTopic, "app-startup"))
>- GetInstance();
>+ NS_RELEASE(GetInstance());
GetInstance can return null so use NS_IF_RELEASE instead.
Attachment #227443 -
Flags: review?(enndeakin) → review+
|
||
Comment 3•18 years ago
|
||
Allow GetInstance to fail.
Attachment #227443 -
Attachment is obsolete: true
|
|
||
Comment 4•18 years ago
|
||
It would be nice if the patch compiled..
Attachment #227449 -
Attachment is obsolete: true
|
||
Updated•18 years ago
|
Component: General → Password Manager
Flags: review+
Product: Core → Firefox
QA Contact: general → password.manager
Version: 1.8 Branch → 2.0 Branch
|
Reporter | |
Comment 6•18 years ago
|
||
Attachment 227455 [details] [diff] was checked in on trunk on 2006-06-28. (mwu, please remember to either resolve bugs or mention their patches were checked in in the bug.)
|
|
||
Comment 7•18 years ago
|
||
Should be fixed by patch in 343022.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•