js errors when changing browser.tabs.disableBackgroundClose and browser.tabs.closeButtons prefs I broke this when I landed my change for bug #318168. but didn't realize it until I was investigating bug #342974 ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "'[JavaScript Error: "this.adjustTabstrip is not a function" {file : "chrome://global/content/bindings/tabbrowser.xml" line: 2451}]' when calling m ethod: [nsIObserver::observe]" nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_E RROR_WITH_DETAILS)" location: "JS frame :: chrome://global/content/config.js :: ModifyPref :: line 521" data: yes] ************************************************************ ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "'[JavaScript Error: "this._updateDisableBackgroundClose is not a function" {file: "chrome://global/content/bindings/tabbrowser.xml" line: 2444}]' when calling method: [nsIObserver::observe]" nsresult: "0x80570021 (NS_ERROR_X PC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: chrome://global/conte nt/config.js :: ModifyPref :: line 514" data: yes] ************************************************************ the fix is simple attaching a patch now.

this patch include a fix for the "too many parentNodes" problem, where if the browser.tabs.closeButtons hidden pref is set to 3, you can't close tabs. note, even though I've patched the pinstripe theme (for parity), pinstripe is still broken (see bug #342974)

the right fix for the pinstripe issue: > Seth, we should really move this to tabbrowser.xml (as a <handler> in > apseudo-private binding?) and expand it in the theme. Anyway, this belongs to > bug 318168 or to a new bug (please CC me if so). I still owe asaf a new bug on this issue.

> I still owe asaf a new bug on this issue. see bug #343061 I've landed my fix on the trunk and if bug #318168 gets approval for the branch, I'll land this regression fix along with it.

Comment on attachment 227482 [details] [diff] [review] patch drivers, if we take bug #318168, we should take this too.

fix checked into the 1.8 branch. (I'm lame for not catching this in my testing before landing on the trunk.)