Closed Bug 343070 Opened 18 years ago Closed 18 years ago

Correct margins in history preference pane

Categories

(Camino Graveyard :: Preferences, defect)

Product:
Camino Graveyard
Component:
Preferences
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Camino1.5

People

(Reporter: froodian, Assigned: froodian)

References

Details

(Keywords: verified1.8.1)

Attachments

(2 files, 6 obsolete files)

Expands space slightly
(deleted), application/zip
mikepinkerton
: superreview+
Details
Screenshot
(deleted), image/png
Details
This is part of preference pane cleanup. (see bug 325880)
Attached file New History.nib (obsolete) (deleted) —
Attachment #227496 - Flags: review?(alqahira)
Attached image Screenshot (obsolete) (deleted) —
Comment on attachment 227496 [details] New History.nib There's extra space on the right, due to the extra length of the text boxes again.
Attachment #227496 - Flags: review?(alqahira) → review-
Comment on attachment 227496 [details] New History.nib Are you sure? Both hint text boxes are pulled exactly to 20px from the end...
Attachment #227496 - Flags: review- → review?(alqahira)
Yes, but both have 15-20px of blank space between the last character and the edge of the box, so it looks like 35-40px.
Attached file Fixes centering (obsolete) (deleted) —
yeah, you're right. sorry about that. :p
Attachment #227496 - Attachment is obsolete: true
Attachment #227523 - Flags: review?(alqahira)
Attachment #227496 - Flags: review?(alqahira)
Attached image Screenshot (obsolete) (deleted) —
Attachment #227497 - Attachment is obsolete: true
Comment on attachment 227523 [details] Fixes centering The bottom rectangle still is longer than its text, which makes the right side look bigger. It's certainly better. Shouldn't we be setting first responder on the text field for when the "force focus highlight on first item" bug is fixed?
Attachment #227523 - Flags: review?(alqahira) → review-
Attached file Centers more betterer (obsolete) (deleted) —
Also fixes initialFirstResponder. Thanks for catching that.
Attachment #227523 - Attachment is obsolete: true
Attachment #227645 - Flags: review?(alqahira)
Attached image Screenshot (obsolete) (deleted) —
Attachment #227524 - Attachment is obsolete: true
Attachment #227645 - Flags: superreview?(mikepinkerton)
i think the vertical compression makes things too busy and hard to separate the differnt prefs visually. Agreement?
Attached file Expands space slightly (deleted) —
Attachment #227645 - Attachment is obsolete: true
Attachment #227645 - Flags: superreview?(mikepinkerton)
Attached image Screenshot (deleted) —
Attachment #227646 - Attachment is obsolete: true
Attachment #230123 - Flags: superreview?(mikepinkerton)
Comment on attachment 230123 [details] Expands space slightly sr=pink
Attachment #230123 - Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [needs checkin]
Fixed trunk and branch.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
Status: RESOLVED → VERIFIED
Keywords: verified1.8.1
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: