Closed Bug 343360 Opened 18 years ago Closed 18 years ago

FileWriter's security check doesn't work with flat chrome

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 3 alpha1

People

(Reporter: asqueella, Assigned: asqueella)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

unbitrotted
(deleted), patch
Gavin
: review+
Details | Diff | Splinter Review 
When you build with --enable-chrome-format=flat, feeds subscription dialog is broken due to FileWriter._isValidWindow function checking that the real URL of the page called into it starts with "jar:file://", which is obviously not true for a app built with flat chrome.

I'm going to change that check to a more restrictive, but at the same time more correct: check that the real URI of the page equals the resolved URI returned by the chrome registry for the subscription page (chrome://browser/content/feeds/subscribe.xhtml)
Attached patch patch (obsolete) (deleted) — — Splinter Review 
Assignee: nobody → asqueella
Status: NEW → ASSIGNED

        Attachment #227840 -
        Flags: review?(bugs)

    
    

    
  
Comment on attachment 227840 [details] [diff] [review]
patch

Please use Cc and Ci and the indentation style used elsewhere in this file.

If you can do that, and attach a new patch I'll check it in. This looks good. We might want to get this for b2 too if we can (since I think your approach is superior to mine).

        Attachment #227840 -
        Flags: review?(bugs) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        style nits fixed (obsolete) (deleted)
        — 
          — Splinter Review
      

    


  

        Attachment #227840 -
        Attachment is obsolete: true

        Attachment #230186 -
        Flags: review?(bugs)

    
    

    
  
Setting target milestone to b2 per ben's comment.
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Firefox 2 beta2

    
    

    
  

      
      
      
      

        Attached patch
          
          
        unbitrotted (deleted)
        — 
          — Splinter Review
      

    


  

        Attachment #230186 -
        Attachment is obsolete: true

        Attachment #235507 -
        Flags: review?(bugs)

        Attachment #230186 -
        Flags: review?(bugs)

    
  
Target Milestone: Firefox 2 beta2 → Firefox 2

    
  
Version: Trunk → 2.0 Branch

    
    

    
  
*** Bug 351726 has been marked as a duplicate of this bug. ***

    
    

    
  
*** Bug 352648 has been marked as a duplicate of this bug. ***

    
  
Target Milestone: Firefox 2 → Firefox 3 alpha1
Version: 2.0 Branch → Trunk

    
  

        Attachment #235507 -
        Flags: review?(bugs) → review?(gavin.sharp)

        Attachment #235507 -
        Flags: review?(gavin.sharp) → review+

    
  
Whiteboard: [checkin needed]

    
    

    
  
mozilla/browser/components/feeds/src/FeedWriter.js 	1.20
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]

    
  
See Also:  → https://launchpad.net/bugs/61182

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: