Closed Bug 343364 Opened 18 years ago Closed 18 years ago

Changing Multiple Bugs is broken on the tip

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

2.23
defect
Not set
critical

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: mkanat, Assigned: bugzilla-mozilla)

References

Details

(Keywords: regression)

Attachments

(1 file)

Trying to change multiple bugs at once gives the error: Can't call method "in_group" on an undefined value at Bugzilla/Bug.pm line 1230. That means that somehow $self->{'who'} is undefined in the bug object at some point, for some reason, during process_bug.cgi.
Attached patch patch, v1 (deleted) — Splinter Review
What is broken is the moving of products. This is because $bug is initialized with a bugnr that does not exists. This causes $self->{'who'} not to be set. Patch just moves the initialization of the code that sets $self->{'who'} up (before returning). Haven't tested if this causes assumptions in other parts of the code to be broken.
Status: NEW → ASSIGNED
Comment on attachment 227845 [details] [diff] [review] patch, v1 >+ if ((! defined $bug_id) || (!$bug_id) || (!detaint_natural($bug_id))) { Nit: even better, write: unless ($bug_id && detaint_natural($bug_id)) { I know this is how the old code is. But this could easily be fixed on checkin. r=LpSolit NB: The funny thing is that I fixed the problem on my side, and when I called "cvs diff", I realized we had the same patch. ;) That's why I renamed your patch from "untested patch" to "patch, v1", because I tested it even before looking at yours.
Attachment #227845 - Attachment description: Untested patch (solves the issue, can cause regressions) → patch, v1
Attachment #227845 - Flags: review+
Reassigning the bug to bkor, as he was faster than me. ;)
Assignee: LpSolit → bugzilla-mozilla
Status: ASSIGNED → NEW
Flags: approval?
Flags: approval? → approval+
Checking in Bugzilla/Bug.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm new revision: 1.125; previous revision: 1.124 done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: