Closed Bug 343449 Opened 18 years ago Closed 18 years ago

NSIS installer doesn't set font for Japanese (ja) and Korean (ko)

Categories

(Firefox :: Installer, defect)

2.0 Branch
x86
Windows 98
defect
Not set
blocker

Tracking

()

VERIFIED FIXED
Firefox 2 beta1

People

(Reporter: masayuki, Assigned: Pike)

References

Details

(Keywords: intl, jp-critical, verified1.8.1)

Attachments

(1 file)

See this screenshot: http://bugzilla.mozilla.gr.jp/attachment.cgi?id=3242&action=view This is Japanese installer dialog on Win98. But the texts are garbled. We don't have same issue on Win2k/XP. I think that this bug same as bug 266309 that cause is the installer didn't set send the WM_SETFONT, so the old installer didn't set the correct font family/size. But we don't have NSIS installer's source code in tree. So, we cannot fix by same approach if the cause is same as bug 266309. We must fix this before release. Because by bug 266309, we could not release minor update at same day in 1.0.x.
I may have a wrong. Asai-san(Japanese Localizer) said, we cannot specify the font of the dialogs of NSIS installer by some setting files. This is my conjecture. The NSIS want to use system default font for the dialogs, but it's failing like as bug 305797.
Flags: blocking-firefox2?
As far as I read the code, preprocess-locale.pl http://lxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/installer/windows/nsis/preprocess-locale.pl will load "ab-CD_font" and "ab-CD_size" in locales.nsi http://lxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/installer/windows/nsis/locales.nsi and after loading some other string definition, finally generate locale file for NSIS installer like: http://nsis.cvs.sourceforge.net/nsis/NSIS/Contrib/Language%20files/Japanese.nlf?view=markup # preprocess-locale.pl and locales.nsi are introduced in attachment 226557 [details] [diff] [review] of # bug 340173 This file contains font setting of NSIS on the top of it and the setting originally come form locales.nsi through preprocess-locale.pl. For ja (Japanese) locale, I think we should set font "‚l‚r ‚oƒSƒVƒbƒN" and size "9" for NSIS as original NSIS do. http://nsis.cvs.sourceforge.net/nsis/NSIS/Contrib/Language%20files/Japanese.nlf?view=markup So, I expect adding below in the locales.nsi will solve this bug. ; Japanese !define ja_font "‚l‚r ‚oƒSƒVƒbƒN" !define ja_size "9" Is this wrong? # Sorry but I don't have build environment and I cannot confirm this...
Korean seems to be affected, too. We don't have this in the localized files, but in locales.nsi. If someone wants to contribute a patch, the fontname must not be copied over but converted to utf-8 before.
Summary: NSIS installer doesn't honor font settings → NSIS installer doesn't set font for Japanese (ja) and Korean (ko)
Target Milestone: Firefox 2 → Firefox 2 beta1
(In reply to comment #3) > Korean seems to be affected, too. > We don't have this in the localized files, but in locales.nsi. > > If someone wants to contribute a patch, the fontname must not be copied over > but converted to utf-8 before. Is current locales.nsi utf-8? It seems for me that zh-CN_font's value is encoded in BG2312, and zh-TW_font's value is encoded in Big5. Both of them are same encoding like just copied over... http://nsis.cvs.sourceforge.net/nsis/NSIS/Contrib/Language%20files/SimpChinese.nlf?view=markup http://nsis.cvs.sourceforge.net/nsis/NSIS/Contrib/Language%20files/TradChinese.nlf?view=markup
Yes, and that's bug 343468, included in the upcoming patch.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
(In reply to comment #6) > Created an attachment (id=227968) [edit] > add ja and ko to locales.nsi, fix the encodings of zh-CN and -TW Oh, you are a little faster than me. ;) As far as I checked, your patch contain correct UTF-8 font names. Thanks.
Flags: blocking-firefox2? → blocking-firefox2+
Whiteboard: [has patch]
This is already fixed on the trunk by the patch in bug 343468.
Fixed on trunk and branch.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [has patch]
-> v. with ja-JP build. Thank you, Axel.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: