Closed
Bug 343554
Opened 18 years ago
Closed 18 years ago
Tab reordering shortcuts can move tabs offscreen
Categories
(Firefox :: Tabbed Browser, defect, P2)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 2 beta1
People
(Reporter: asaf, Assigned: asaf)
References
Details
(Keywords: fixed1.8.1, regression)
Attachments
(1 file)
|
(deleted),
patch
|
mconnor
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
I'm running into various senarios in which the selected tab isn't visible.
One senario:
1. Open many tabs.
2. Select and focus the last tab.
3. Press Ctrl+Home (selects the first tab).
One reason would be the use of this.selectedItem in the TabSelect handler. IIRC it still points to the previously selected tab at this point. Unfortunately, even after changing it to use this.childNodes[this.selectedIndex] (which should be fine, see updateCurrentBrowser), this handler doesn't really do its job.
|
Assignee | |
Updated•18 years ago
|
Flags: blocking-firefox2?
|
||
Comment 1•18 years ago
|
||
So, Ctrl+Home moves that tab to the first position, so it misses the tabselect handler entirely. Same problem with Ctrl+Left/Right and Ctrl+End, easy to reproduce.
We should add a tabmove handler to do the same as the tabselect handler and always ensure the tab is visible. Not critical path for b1, but should be fixed.
Flags: blocking-firefox2? → blocking-firefox2+
Summary: Invisible selected tabs → Tab reordering shortcuts can move tabs offscreen
Target Milestone: --- → Firefox 2 beta2
|
|
Assignee | |
Updated•18 years ago
|
Assignee: nobody → bugs.mano
Priority: -- → P2
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•18 years ago
|
||
Attachment #228135 -
Flags: review?(mconnor)
|
|
||
Updated•18 years ago
|
Attachment #228135 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Comment on attachment 228135 [details] [diff] [review]
patch
This should be safe enough for b1.
Attachment #228135 -
Flags: approval1.8.1?
|
|
Assignee | |
Comment 4•18 years ago
|
||
trunk: mozilla/toolkit/content/widgets/tabbrowser.xml 1.162
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Attachment #228135 -
Flags: approval1.8.1? → approval1.8.1+
|
|
Assignee | |
Comment 5•18 years ago
|
||
1.8 branch: mozilla/toolkit/content/widgets/tabbrowser.xml 1.103.2.52
Keywords: fixed1.8.1
Target Milestone: Firefox 2 beta2 → Firefox 2 beta1
You need to log in
before you can comment on or make changes to this bug.
Description
•