Closed Bug 343708 Opened 18 years ago Closed 18 years ago

Crash when opening Firefox prefwindow (since JS 1.7 alpha trunk landing)

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: Waldo, Assigned: brendan)

References

Details

(Keywords: crash)

Attachments

(1 file, 1 obsolete file)

better fix
(deleted), patch
mrbkap
: review+
Details | Diff | Splinter Review
From word on the street it sounds like the crash is cross-platform. I'd post a backtrace except that I'm at least an hour away from a trunk build with JS1.7.
Blocks: js1.7
Attached patch fix (obsolete) (deleted) — — Splinter Review
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #228256 - Flags: review?(mrbkap)
Attached patch better fix (deleted) — — Splinter Review
Equivalent to original patch, but more consistent: *all* code generation is done under FunctionBody when called with a tc that is-a cg. This simplified logic in the one call to the static FunctionBody that passes such a code generator's tc, js_CompileFunctionBody. /be
Attachment #228256 - Attachment is obsolete: true
Attachment #228257 - Flags: review?(mrbkap)
Attachment #228256 - Flags: review?(mrbkap)
Fixed, mrbkap can stamp when he gets back from hockey. This one was a late-breaking regression, from today's farbling to fix a regression in the JS_1_7_ALPHA_BRANCH introduced with block scope ("let"). Should have seen it much sooner, and we need testsuite support to catch it. It requires something like XBL's call to JS_CompileUCFunctionForPrincipals call that compiles an XBL method. /be
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #228257 - Flags: review?(mrbkap) → review+
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: