Closed
Bug 343784
Opened 18 years ago
Closed 18 years ago
home page not migrated
Categories
(Firefox :: Migration, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: jbecerra, Assigned: masayuki)
References
Details
(Keywords: fixed1.8.1, regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mconnor
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.5) Gecko/2006070513 Firefox/1.5.0.5
Home Page is not migrated as part of the profile migration.
To recreate:
1. Remove your Firefox folder from the Application Support/Mozilla directory
2. Use Mozilla 1.7.x (1.7.13 used) and add some bookmarks, save some passwords, etc..., and set your home page to something like www.slashdot.org
3. Launch Firefox and when the migration wizard comes up choose to migrate data from Mozilla, including the dialog that prompts to set the Home Page to the one used Mozilla
4. After FF starts click on the Home Page icon to go to the home page
Expected: You should be redirected to the Home Page set for Mozilla which we migrated, www.slashdot.org for example.
Actual: The Firefox Start page with the google search bar appears
Comment 1•18 years ago
|
||
this worked in 1.5 and 1.5.0.1. It has been broken since 1.5.0.2 specifically broken between 20060220 and 20060222.
cc'ing masayuki. checkin during that time frame is likely suspect.
Keywords: regression
Updated•18 years ago
|
Flags: blocking1.8.0.6?
Comment 2•18 years ago
|
||
Check-in range:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=MOZILLA_1_8_0_BRANCH&branchtype=match&dir=mozilla%2Fbrowser%2Fcomponents%2Fmigration&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-02-20&maxdate=2006-02-22&cvsroot=%2Fcvsroot
Tracy forgot to mention it, but the bug that regressed this is bug 327303.
Assignee | ||
Comment 3•18 years ago
|
||
http://lxr.mozilla.org/mozilla/source/browser/components/migration/content/migration.js#465
On the case is "Migration:Ended" in observe, |this._newHomePage| has correct value. But it's not saved if from Seamonkey. Why?
Assignee | ||
Comment 4•18 years ago
|
||
I should not have removed the code of reading/saving by prefService.
But we need to save prefs before reset for others.
Assignee | ||
Comment 5•18 years ago
|
||
Comment on attachment 228405 [details] [diff] [review]
Patch rv1.0
Sorry. It's very risky. The saving may destroy original(other browser's) profile.
Attachment #228405 -
Flags: review?(mconnor) → review-
Assignee | ||
Comment 6•18 years ago
|
||
This is better.
Attachment #228405 -
Attachment is obsolete: true
Attachment #228428 -
Flags: review?(mconnor)
Comment 7•18 years ago
|
||
Need a reviewed patch landed on trunk and 1.8-branch before we can consider non-security fixes for the 1.8.0 branch. Not making 1.8.0.7
Flags: blocking1.8.0.7? → blocking1.8.0.7-
Reporter | ||
Comment 8•18 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060816 BonEcho/2.0b1
This also has the same problem.
Updated•18 years ago
|
Flags: blocking-firefox2+
Comment 9•18 years ago
|
||
Comment on attachment 228428 [details] [diff] [review]
Patch rv2.0
ok, that looks good, thanks Masayuki!
Attachment #228428 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 10•18 years ago
|
||
checked-in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•18 years ago
|
||
Comment on attachment 228428 [details] [diff] [review]
Patch rv2.0
Let's go to 1.8.1 branch.
Attachment #228428 -
Flags: approval1.8.1?
Comment 12•18 years ago
|
||
Comment on attachment 228428 [details] [diff] [review]
Patch rv2.0
a=beltzner on behalf of drivers, please land on MOZILLA_1_8_BRANCH
Attachment #228428 -
Flags: approval1.8.1? → approval1.8.1+
You need to log in
before you can comment on or make changes to this bug.
Description
•