Closed Bug 344264 Opened 18 years ago Closed 18 years ago

In <button.xml>, multiple Strict "Warning: function onxblkeypress does not always return a value"

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.8.1beta2

People

(Reporter: zeniko, Assigned: zeniko)

References

(
URL
)

Details

(Keywords: fixed-seamonkey1.1a, fixed1.8.1, Whiteboard: [verified-seamonkey1.1a])

Attachments

(1 file, 2 obsolete files)

unbitrotted fix for Toolkit and XPFE
(deleted), patch
mconnor
: approval1.8.1+
Details | Diff | Splinter Review
Warning: function onxblkeypress does not always return a value Source file: chrome://global/content/bindings/button.xml Line: 172, Column: 5 Source code: ---------- Warning: function onxblkeypress does not always return a value Source file: chrome://global/content/bindings/button.xml Line: 162, Column: 18 Source code: return; ---------- Warning: function onxblkeypress does not always return a value Source file: chrome://global/content/bindings/button.xml Line: 153, Column: 16 Source code: return; ---------- Warning: function onxblkeypress does not always return a value Source file: chrome://global/content/bindings/button.xml Line: 145, Column: 16 Source code: return; // No printable char pressed, not a potential accesskey Steps to Reproduce: * Enable the pref javascript.options.strict * Load the URL Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060711 BonEcho/2.0b1 Firefox/1.5 ID:2006071104
Blocks: 296661
Severity: normal → trivial
Attached patch don't return useless values (obsolete) (deleted) — — Splinter Review
Assignee: nobody → zeniko
Status: NEW → ASSIGNED
Attachment #228836 - Flags: first-review?(mconnor)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b1) Gecko/20060711 SeaMonkey/1.1a] (nightly) (W98SE) [ Warning: function onxblkeypress does not always return a value Source File: chrome://global/content/bindings/button.xml Line: 156, Column: 16 Source Code: return; // No printable char pressed, not a potential accesskey Warning: function onxblkeypress does not always return a value Source File: chrome://global/content/bindings/button.xml Line: 164, Column: 16 Source Code: return; Warning: function onxblkeypress does not always return a value Source File: chrome://global/content/bindings/button.xml Line: 173, Column: 18 Source Code: return; Warning: function onxblkeypress does not always return a value Source File: chrome://global/content/bindings/button.xml Line: 183, Column: 5 Source Code: ]
Severity: trivial → minor
Component: XUL Widgets → XP Toolkit/Widgets
Flags: first-review?(mconnor)
Product: Toolkit → Core
Summary: Strict warnings in button.xml → In <button.xml>, multiple Strict "Warning: function onxblkeypress does not always return a value"
Version: unspecified → 1.8 Branch
Attachment #228836 - Flags: review?(mconnor)
Attached patch fix for Toolkit and XPFE (obsolete) (deleted) — — Splinter Review
Attachment #228836 - Attachment is obsolete: true
Attachment #229006 - Flags: review?(mconnor)
Attachment #228836 - Flags: review?(mconnor)
Attachment #229006 - Flags: superreview?(neil)
Comment on attachment 229006 [details] [diff] [review] fix for Toolkit and XPFE For some reason the owner of bug 343690 hasn't checked his patch in so you'll find you'll need to update this patch when he does.
Attachment #229006 - Flags: superreview?(neil) → superreview+
The checkin for that other bug happened today [ 2006-07-17 06:38 smontagu%smontagu.org ]
I hope this one can be prioritized, as I get it all the time when using Ctrl-Enter to send an email. [And as I have an added getAttention() in my local install...]
Flags: blocking1.8.1?
Target Milestone: --- → mozilla1.8.1beta2
Comment on attachment 229006 [details] [diff] [review] fix for Toolkit and XPFE r=me, please request approval on the updated patch when its done
Attachment #229006 - Flags: review?(mconnor) → review+
Not going to block on this, but if a well-baked patch exists and gets nominated for approval1.8.1 tomorrow, we'd like to take it!
Flags: blocking1.8.1? → blocking1.8.1-
Attachment #229006 - Attachment is obsolete: true
Attachment #229887 - Flags: approval1.8.1?
Whiteboard: [checkin needed]
mozilla/xpfe/global/resources/content/bindings/button.xml 1.33 mozilla/toolkit/content/widgets/button.xml 1.17
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Attachment #229887 - Flags: approval1.8.1? → approval1.8.1+
Whiteboard: [checkin needed (1.8 branch)]
mozilla/xpfe/global/resources/content/bindings/button.xml 1.27.4.4 mozilla/toolkit/content/widgets/button.xml 1.12.4.4
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b1) Gecko/20060723 SeaMonkey/1.1a] (nightly) (W98SE) V.Fixed on MOZILLA_1_8_BRANCH. Thanks !
Keywords: fixed-seamonkey1.1a
Whiteboard: [verified-seamonkey1.1a]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: