Closed
Bug 344384
Opened 18 years ago
Closed 18 years ago
Double-click-drag misbehaves when dragging into empty lines (created by <br><br>)
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
People
(Reporter: uriber, Assigned: uriber)
References
Details
Attachments
(2 files)
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
In the textarea above, type a few words, hit enter twice, then type some more.
Now double-click-and-drag from (e.g.) the last word in the top line into the empty line. Notice that the selection suddenly starts at the second word of the line.
The problem is not limited to textareas - it can be triggered by <br><br> in HTML.
I'll attach a patch soon.
Assignee | ||
Comment 1•18 years ago
|
||
GetPrimaryFrameFor doesn't work for non-text frames. GetFrameForNodeOffset is what I really want.
Sorry for not catching this earlier.
Assignee: selection → uriber
Status: NEW → ASSIGNED
Attachment #228972 -
Flags: superreview?(roc)
Attachment #228972 -
Flags: review?(roc)
Comment on attachment 228972 [details] [diff] [review]
patch
I should have caught that too.
Attachment #228972 -
Flags: superreview?(roc)
Attachment #228972 -
Flags: superreview+
Attachment #228972 -
Flags: review?(roc)
Attachment #228972 -
Flags: review+
Assignee | ||
Comment 3•18 years ago
|
||
I had to update for bug 343763, and I also added a null check on |frame|, just to be sure.
Assignee | ||
Comment 4•18 years ago
|
||
Checking in layout/generic/nsSelection.cpp;
/cvsroot/mozilla/layout/generic/nsSelection.cpp,v <-- nsSelection.cpp
new revision: 3.247; previous revision: 3.246
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•