Closed
Bug 345327
Opened 18 years ago
Closed 18 years ago
Clear button does not work
Categories
(Toolkit Graveyard :: Error Console, defect)
Toolkit Graveyard
Error Console
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: polidobj, Assigned: zeniko)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
The clear button does not clear the error console. Although after pressing the clear button then closing and reopening the console, then the console is cleared.
Recently There was a leak in the console (bug 344625) which appears to have been fixed by bug 344623. I'm not sure if that's related.
|
||
Comment 1•18 years ago
|
||
Seems to me like the logStringMessage(null) call should be after the .reset() call instead of before.
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/console/content/consoleBindings.xml&rev=1.12&mark=208#205
Blocks: 322169
|
Assignee | |
Comment 2•18 years ago
|
||
Seems that I forgot to remove this check when porting the patch to the clean CVS tree. Sorry for this breakage.
The issue is that the "null" messages which have so far been used to mark the point until which messages should be displayed in the console and which are now used to indicate that an open console should be cleared are prematurely discarded.
|
|
Assignee | |
Updated•18 years ago
|
|
||
Comment 3•18 years ago
|
||
*** Bug 345374 has been marked as a duplicate of this bug. ***
|
|
Assignee | |
Updated•18 years ago
|
Target Milestone: Firefox 2 beta2 → Firefox 3 alpha1
|
||
Updated•18 years ago
|
Attachment #229972 -
Flags: review?(mconnor) → review+
|
|
||
Comment 4•18 years ago
|
||
mozilla/toolkit/components/console/content/consoleBindings.xml 1.13
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 5•18 years ago
|
||
*** Bug 346210 has been marked as a duplicate of this bug. ***
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
|
|
||
Updated•8 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•