Closed
Bug 345395
Opened 18 years ago
Closed 18 years ago
Semicolon needs to be removed from nsPasswordManager.cpp
Categories
(Toolkit :: Password Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1beta2
People
(Reporter: mwu, Assigned: mwu)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
I screwed up. LoadPasswords has an extra semicolon on the line that checks for the return value of ReadPasswords. It doesn't make any difference for the most part, but it makes the return value check pointless.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #230046 -
Flags: review?(enndeakin)
|
||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Version: Trunk → 2.0 Branch
|
|
||
Updated•18 years ago
|
Whiteboard: [checkin needed] [checkin needed (1.8 branch)]
|
|
Assignee | |
Updated•18 years ago
|
Attachment #230046 -
Flags: review?(enndeakin)
|
||
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed] [checkin needed (1.8 branch)] → [checkin needed (1.8 branch)]
|
||
Comment 2•18 years ago
|
||
What's the deal here? Are we going to need to get this reviewed and request approval1.8.1? IMO this should just be checked in. It was a simple typo.
|
||
Comment 3•18 years ago
|
||
patch checked in on branch
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•