Closed Bug 345583 Opened 18 years ago Closed 18 years ago

Hang involving large -moz-column-count

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: j.moz, Assigned: MatsPalmgren_bugz)

References

(
URL
)

Details

(4 keywords)

Attachments

(2 files)

testcase (hangs the browser)
(deleted), text/html
Details
wallpaper
(deleted), patch
roc
: review+
roc
: superreview+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060721 Minefield/3.0a1

If you visit the url in the URL field (iExploder test 13058), the browser
hangs.

Found using http://toadstool.se/software/iexploder/
Attached file testcase (hangs the browser) (deleted) — 
The source is:

<body style="-moz-column-count: 1111111">
<h1 style="height: 1111111">
Blocks: iexploder
Keywords: testcase
This hangs Bon Echo too.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060722 BonEcho/2.0b1
-> Layout
Component: General → Layout
Product: Firefox → Core
QA Contact: general → layout
Summary: Hang with iExploder test 13058 → Hang involving large -moz-column-count
Confirmed with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060721 Minefield/3.0a1.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
iExploder seems to generate this hang a lot: I believe tests 13058, 25154, 25483, 44142, 68521, 70491, 70816, 73939, 85372, 103036, 104579, 139897, 175555, 193312, 203003, 212765, 244770, 249098, 262674, 265318, 286541, 290849, 294567, 297381, 317804, 318021 etc. all hang because of this bug.

Replacing the string "column" with something else in those tests made the hang go away, that's why I think they have something to do with this bug.

This hang is so common it makes identifying other hangs with iExploder difficult.
Flags: blocking1.9?
Flags: blocking1.8.1?
Flags: blocking1.8.1? → blocking1.8.1+
Target Milestone: --- → mozilla1.8.1
--> Dbaron - can you take a quick look?
Assignee: nobody → dbaron
Attached patch wallpaper (deleted) — — Splinter Review 
I'm guessing this is more of a performance problem than a real hang.
Limiting the number of columns "fixes" this bug, in case we run
out of time for a real fix...
Keywords: perf
It's not immediately clear what a real fix should look like. If you ask for N columns and give us content that can break over N columns, then the correct thing to do is to create N columns. We could impose a minimum column width C, perhaps, but that would be defeated just by putting the N columns in a container of width N*C.
Comment on attachment 235533 [details] [diff] [review]
wallpaper

I'm happy with this wallpaper fix if no-one can suggest a more reasonable way around the problem.
Attachment #235533 - Flags: superreview+
Attachment #235533 - Flags: review+
Whiteboard: [checkin needed]
Guess it is time for the wallpaper...
Assignee: dbaron → mats.palmgren
Checked in to trunk at 2006-09-11 17:37 PDT.

-> FIXED
Status: NEW → RESOLVED
Closed: 18 years ago
Flags: blocking1.9?
Resolution: --- → FIXED
In table land we have the advanced version of this wallpaper 
if colspan > 1000 
 *they* attack us
 colspan = 1;
Opera and IE do the same but it took ages for me to realize this.
Ready for 1.8.1 branch?
Attachment #235533 - Flags: approval1.8.1?
Comment on attachment 235533 [details] [diff] [review]
wallpaper

a=schrep for 181drivers
Attachment #235533 - Flags: approval1.8.1? → approval1.8.1+
Whiteboard: [checkin needed] → [checkin needed (1.8 branch)]
Checked in to MOZILLA_1_8_BRANCH at 2006-09-13 18:28 PDT.
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
I filed bug 421673 which is similar to this bug.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: