Closed
Bug 346802
Opened 18 years ago
Closed 18 years ago
session restore dialog thinks shutting down w32 is a "serious error"
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: beltzner, Assigned: beltzner)
Details
(Keywords: fixed1.8.1, late-l10n, polish)
Attachments
(1 file)
|
(deleted),
patch
|
Gavin
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Oops. Bug 337390 neglected to realize that if a user shuts down Windows XP without first closing Firefox, they'll get the Session Restore bug when they next start up. That's not a "serious error". Patch coming up to change the string so it's less scary.
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 2 beta2
|
||
Updated•18 years ago
|
Assignee: nobody → beltzner
Status: ASSIGNED → NEW
Flags: blocking-firefox2?
|
|
||
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #231553 -
Flags: review?(gavin.sharp)
|
||
Updated•18 years ago
|
Attachment #231553 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [checkin needed]
|
|
||
Comment 2•18 years ago
|
||
Comment on attachment 231553 [details] [diff] [review]
changes to strings and entity names
Requesting a1.8.1. Just a string and entity name change.
Attachment #231553 -
Flags: approval1.8.1?
|
|
||
Comment 3•18 years ago
|
||
mozilla/browser/locales/en-US/chrome/browser/sessionstore.properties 1.4
mozilla/browser/components/sessionstore/src/nsSessionStartup.js 1.9
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed] → [needs approval]
|
||
Updated•18 years ago
|
Attachment #231553 -
Flags: approval1.8.1? → approval1.8.1+
|
|
||
Updated•18 years ago
|
Whiteboard: [needs approval] → [checkin needed (1.8 branch)]
|
||
Comment 4•18 years ago
|
||
patch checked in on MOZILLA_1_8_BRANCH
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
|
||
Comment 5•18 years ago
|
||
(In reply to comment #1)
> Created an attachment (id=231553) [edit]
> [...] if you think the problem was related to [...]
Isn't that still confusing?
And why doesn't Firefox store the data properly anyway? I think Windows is very generous when shutting down. Other applications have even time to ask the user whether he wants to save his data or not.
|
|
||
Updated•18 years ago
|
Flags: blocking-firefox2?
|
||
Comment 6•18 years ago
|
||
I filed a new bug on the remaining confusion and arguably sub-optimal default behavior:
Bug 358667 - Session Store should not restore after a user-initiated OS shutdown.
You need to log in
before you can comment on or make changes to this bug.
Description
•