Problems: 1) Not in the tab chain at all (even with FKA on) 2) Esc doesn't close* 3) Buttons should probably have non-conflicting kybd shortcuts (since it's non-blocking) [Cmd-U is fine for now, but if we change the name when we separate 'show' and 'whitelist' it may not fit) 4) Others? * Possible conflict depending on page load issues

As the nib stands in bug 331331, the close button's not in the tab chain, but since you can't get into that nib at all anyway, it doesn't matter for now.

This is almost WFM now; everything is in the tab chain. I disagree that the buttons need shortcuts... just focusing and hitting tab to click them is enough. The only thing needed would be to change the in the nib so the close button has some "close" accessible title (for VoiceOver etc).

s/tab/space

(In reply to comment #2) Is this working for you in conjunction with the other key view loop and tabbing behavior patches you've been developing, or on a trunk build?

(In reply to comment #4) > (In reply to comment #2) > > Is this working for you in conjunction with the other key view loop and tabbing > behavior patches you've been developing, or on a trunk build? IIRC, I was just testing with a trunk build which things were focusable when tabbing around in the browser window.

Setting priority per 1.6 roadmap.

Håkan, do you have any time to work on this in the next month?

Probably not.

I think I can give it a shot, Sam. A month or so back I worked at establishing a key-view loop throughout the entire browser window. Now that the search editor and OpenSearch patches are in, I'll make time to revisit that work and hopefully I can get something submitted.

Pushing this out to 2.0 like bug 152987; it's too late to take it now without having seen a patch yet, but Sean's got some work done, so we really want to fix this for 2.0.

Fixed on cvs trunk by the checkin for bug 152987; thanks Sean! If you see a regression or, more likely, a case where the new loop breaks, please file a follow-up bug.