Closed
Bug 346922
Opened 18 years ago
Closed 18 years ago
assertions should be fatal when running unit tests
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: Biesinger, Assigned: Biesinger)
References
Details
Attachments
(1 file)
(deleted),
patch
|
davel
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
Since assertions mean that there's a bug somewhere, and unit tests should ensure that there are no bugs, assertions should be fatal so that they can easily be caught.
Assignee | ||
Comment 1•18 years ago
|
||
Assignee: nobody → cbiesinger
Status: NEW → ASSIGNED
Attachment #231840 -
Flags: superreview?(darin)
Attachment #231840 -
Flags: review?(davel)
Assignee | ||
Updated•18 years ago
|
OS: Linux → All
Hardware: PC → All
Updated•18 years ago
|
Attachment #231840 -
Flags: superreview?(darin) → superreview+
Comment 2•18 years ago
|
||
Comment on attachment 231840 [details] [diff] [review]
patch
assuming XPCOM_DEBUG_BREAK is the right env var to set . . .
Have you run the netwerk and content tests with this patch?
Attachment #231840 -
Flags: review?(davel) → review+
Assignee | ||
Comment 3•18 years ago
|
||
I did run the netwerk tests (compare bug 346939 which was exposed by that); I'll run the content tests before checking this in.
Assignee | ||
Comment 4•18 years ago
|
||
make check from toplevel passed, checked in
Checking in test_all.sh;
/cvsroot/mozilla/tools/test-harness/xpcshell-simple/test_all.sh,v <-- test_all.sh
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•