Closed
Bug 347242
Opened 18 years ago
Closed 18 years ago
Strict warnings in notification.xml
Categories
(Toolkit :: XUL Widgets, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.8.1beta2
People
(Reporter: zeniko, Assigned: whimboo)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
(deleted),
patch
|
robert.strong.bugs
:
first-review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Warning: assignment to undeclared variable n
Source file: chrome://global/content/bindings/notification.xml
Line: 77
----------
Warning: assignment to undeclared variable opacitychange
Source file: chrome://global/content/bindings/notification.xml
Line: 174
|
Reporter | |
Updated•18 years ago
|
Whiteboard: [good first bug]
|
Assignee | |
Comment 1•18 years ago
|
||
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #232090 -
Flags: first-review?(mconners)
|
|
Assignee | |
Updated•18 years ago
|
Attachment #232090 -
Flags: first-review?(mconners) → first-review?(robert.bugzilla)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 232090 [details] [diff] [review]
Patch
Thanks for the patch
Attachment #232090 -
Flags: first-review?(robert.bugzilla) → first-review+
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [good first bug] → [checkin needed]
|
||
Comment 3•18 years ago
|
||
mozilla/toolkit/content/widgets/notification.xml 1.6
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha1
Version: unspecified → Trunk
|
|
Reporter | |
Comment 4•18 years ago
|
||
Comment on attachment 232090 [details] [diff] [review]
Patch
Drivers: This is a trivial, virtually risk-free patch. It only inserts two missing variable declarations in order to keep the Error Console cleaner.
Attachment #232090 -
Flags: approval1.8.1?
|
||
Comment 5•18 years ago
|
||
Comment on attachment 232090 [details] [diff] [review]
Patch
a=schrep for drivers.
Attachment #232090 -
Flags: approval1.8.1? → approval1.8.1+
|
|
Reporter | |
Updated•18 years ago
|
Whiteboard: [checkin needed (1.8 branch)]
|
|
Assignee | |
Updated•18 years ago
|
Status: RESOLVED → VERIFIED
|
|
||
Comment 6•18 years ago
|
||
mozilla/toolkit/content/widgets/notification.xml 1.1.2.5
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: mozilla1.9alpha1 → mozilla1.8.1beta2
Version: Trunk → 1.8 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•