With the new Pinstripe "visual refresh," the page title and close box in a tab shift to the right when the tab switches from active to background, and then shift back left when the tab is reactivated. To reproduce, open multiple tabs, and switch between them. This transition is visually jarring. The favicon does not shift when switching tabs.

GIF because it's good for animations, grayscale because GIF sucks.

Comment on attachment 233347 [details] [diff] [review] patch r+a=me (1.8 branch only at this point)

Checking in toolkit/themes/pinstripe/global/browser.css; /cvsroot/mozilla/toolkit/themes/pinstripe/global/browser.css,v <-- browser.css new revision: 1.7.4.8; previous revision: 1.7.4.7 done

It's better, but I still see occasional 1px shifts. With a browser window 888px wide (|javascript:window.resizeTo(888,9999);|) and 5 tabs open, the second tab's title, but not close box, shifts 1px to the left when the tab is inactive. When the tab is inactive, it also has the bug 347482 vertical line in it; so does the fourth tab, which does not have a shifting title. I don't believe the title or icon makes a difference, but for reproducability, I do see this bug when all five tabs have loaded about:blank.

I also see this after focusing the location bar, pressing "w", seeing a 2-line autocomplete box, and typing a few other characters to make the autocomplete box disappear. The area that had been obscured by the autocomplete box is redrawn in its proper location.

that looks related to the intermittent 1px gaps on even numbered tabs, which is bug 347482 help tracking that down would be awesome!

here's something odd: for the tab-text, the border-top, bottom, left, and right are 1.86667px for me (when I check with DOMi).

the 1.86667 px = 1.4pt, I think (from http://lxr.mozilla.org/mozilla1.8/source/toolkit/themes/pinstripe/global/browser.css#64) seeing what happens if I do 2px instead.

> seeing what happens if I do 2px instead. nothing, a wild goose. Interestingly, in DOMi, the box width for tab-text is 112 px, but in the computed style, it's 110.4 px. but back to something mconnor wrote, if i twiddle the opacity of the just the tab-text between 1.0 and 0.6, the text "shifts" as mark reports in comment #7, which resembles weirdness seen in bug #347482

Connor thinks this is the other rounding error (bug 347482), so we're marking this one fixed.

> It's better, but I still see occasional 1px shifts. mark: I've just checked in the change for bug #350139, so this is now fixed on mac (branch) too.

That looks pretty good and will take care of the last complainers on bug 347468. Seth, if you open enough tabs that the close boxes disappear on the backgrounded ones, the title now shifts left when a tab is activated and right when it's backgrounded. Do you want a new bug for this, or should we reopen? Also, the text of a tab is now displayed too high vertically relative to the favicon and the close button. The tab height appears to have grown, this could be the problem. New bug, or reopen?

mark, thanks for trying out the latest changes and reporting back. > if you open enough tabs that the close boxes disappear on the > backgrounded ones, the title now shifts left when a tab is activated and right > when it's backgrounded. Do you want a new bug for this, or should we reopen? Good eye! Now that you point it out, I see it. I think it is a side effect caused by the title being centered on mac and the hiding (and showing) of the close box. I'll log a new bug for this. > Also, the text of a tab is now displayed too high vertically relative to the > favicon and the close button. The tab height appears to have grown, this > could be the problem. New bug, or reopen? I'm seeing that, too. I'll log a bug. Part of my last change to mozilla/toolkit/themes/pinstripe/global/browser.css vertically centered the text within the tab (and with respect to the background gradient of the tab), and I thought I had it all lined up, but now I'm seeing what you describe. After staring at things for a while, I see a couple other "off by 1 px" issues with pinstripe I need to chase down. I'll log bugs and cc you. Thanks again, Mark.

mark, I've logged: bug #351433: [pinstripe] when close box only appears on selected tab, title shifts to the left when tab is selected bug #351435: [pinstripe] the text of a tab is now displayed too high vertically relative to the avicon and the close button