Closed
Bug 347822
Opened 18 years ago
Closed 18 years ago
mysql_num_rows() warning when uploading extension
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fligtar, Assigned: morgamic)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
cameron
:
first-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
PHP gives a warning when uploading an extension:
Warning: Wrong parameter count for mysql_num_rows() in /developers/additem.php on line 319
mysql_num_rows() only takes the result resource, not the connection.
Reproducible: Always
|
Reporter | |
Comment 1•18 years ago
|
||
Patches developers/additem.php to remove the bad parameter. Note that this will actually make the duplicate version check work now, so it won't be possible to upload a version with the same version number as an existing one.
Attachment #232642 -
Flags: first-review?(morgamic)
I'm wondering why we don't already have a bug on this!
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
|
Assignee | |
Comment 3•18 years ago
|
||
Comment on attachment 232642 [details] [diff] [review]
patch
This was a stupid error on my part. The error was good, though, since we still do want to allow multiple files per version -- which would be impossible if this piece was working. I have a patch for the dupe version check that allows the multiple-files-per-os scenario.
Attachment #232642 -
Flags: first-review?(morgamic) → first-review-
|
|
Assignee | |
Comment 4•18 years ago
|
||
Attachment #232642 -
Attachment is obsolete: true
Attachment #232741 -
Flags: first-review?(fligtar)
Attachment #232741 -
Flags: first-review?(fligtar) → first-review+
|
|
Assignee | |
Comment 6•18 years ago
|
||
This has been checked in. Will be pushed with next update.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•