Closed
Bug 347872
Opened 18 years ago
Closed 18 years ago
make suiterunner not package about:plugins twice
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
benjamin
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
This is a small, simple followup to bug 328678 - Benjamin moved about:plugins stuff into toolkit but left the lines packaging it from xpfe/global/jar.mn in the area of the file that is packaged by every consumer of xpfe/global.
Those two lines should go into the #ifndef MOZ_XUL_APP block, as toolkit-based apps already package it over in toolkit and don't need to attempt that from here as well.
Patch following in a minute...
|
Assignee | |
Comment 1•18 years ago
|
||
Here's the patch, as I said in comment #0, it's simply moving those two lines into the |#ifndef MOZ_XUL_APP| block, so that toolkit-based apps only pack this from toolkit/ and not from xpfe/.
The other reason is that it makes the stuff we still need to sort out for bug 336874 more visible.
Assignee: jag → kairo
Status: NEW → ASSIGNED
Attachment #232715 -
Flags: superreview?(jag)
Attachment #232715 -
Flags: review?(benjamin)
|
||
Updated•18 years ago
|
Attachment #232715 -
Flags: review?(benjamin) → review+
|
||
Updated•18 years ago
|
Attachment #232715 -
Flags: superreview?(jag) → superreview+
|
|
Assignee | |
Comment 2•18 years ago
|
||
Checked in, thanks for the fast reviews!
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•