Closed Bug 347949 Opened 18 years ago Closed 18 years ago

Crash [@ nsFrameManager::RemoveFrame] when removing display:table style on html element and some other stuff

Categories

(Core :: Layout, defect)

x86
Windows XP
defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: martijn.martijn, Unassigned)

References

Details

(Keywords: crash, regression, testcase)

Crash Data

Attachments

(1 file)

See upcoming testcase, that crashes current trunk builds on load. It doesn't crash on branch builds. Talkback ID: TB21916184G nsFrameManager::RemoveFrame nsCSSFrameConstructor::ReconstructDocElementHierarchyInternal This regressed between 2005-10-16 and 2005-10-17. I backed out the patch for bug 311615 and after that I didn't see the crash anymore in my debug build.
Attached file testcase (deleted) —
So the problem is that we call NeedSpecialFrameReframe(), which calls FindNextSibling() without passing it a child. So FindNextSibling() returns the caption, we end up with a table outer frame for our parent, and then everything goes to hell... Should NeedSpecialFrameReframe pass in the child to FindNextSibling()? Doing that does fix this bug. But then again, given the existing bugs in IsValidSibling for replaced elements, would we still lose in general?
Flags: blocking1.9?
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WORKSFORME
Flags: blocking1.9?
Crash Signature: [@ nsFrameManager::RemoveFrame]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: