Closed
Bug 348319
Opened 18 years ago
Closed 18 years ago
Some inactive toolbar buttons (back button) are highlighted on mouse click
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
VERIFIED
FIXED
Firefox 2
People
(Reporter: wildmyron, Assigned: Gavin)
References
(Depends on 1 open bug)
Details
(Keywords: verified1.8.1, Whiteboard: [Fx2 theme change])
Attachments
(3 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060810 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060810 BonEcho/2.0b1
When some of the toolbar buttons are inactive, clicking on them will cause them to highlight. I have noticed this with the back and forward dropdown buttons, the refresh button, the copy button and the paste button. This doesn't happen with the stop, report site and cut buttons. This is related to the visual refresh for 2.0.
I couldn't find any other buttons which would have an inactive state.
Screenshot to follow.
Build ID: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060810 BonEcho/2.0b1 ID:2006081003
Reproducible: Always
Reporter | ||
Comment 1•18 years ago
|
||
Screenshot showing affect when clicking on back button
Updated•18 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•18 years ago
|
||
Not sure if this affects pinstripe too, Adam is testing.
Comment 3•18 years ago
|
||
Not as much seems to be affected on Mac, but I probably missed something...
Attachment #233280 -
Flags: review?(mconnor)
Assignee | ||
Comment 4•18 years ago
|
||
*** Bug 348572 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•18 years ago
|
Attachment #233248 -
Attachment description: make sure disabled styles take precedence (winstripe patch) → make sure disabled styles take precedence (winstripe)
Comment 5•18 years ago
|
||
I would rather do :not([disabled="true"] everywhere :active is used.
Comment 6•18 years ago
|
||
*** Bug 348658 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•18 years ago
|
Summary: Some inactive toolbar buttons are highlighted on mouse click → Some inactive toolbar buttons (back button) are highlighted on mouse click
Assignee | ||
Comment 7•18 years ago
|
||
*** Bug 350108 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•18 years ago
|
Whiteboard: [patch-r?]
Comment 8•18 years ago
|
||
*** Bug 350598 has been marked as a duplicate of this bug. ***
Comment 9•18 years ago
|
||
This is a DUPE of the new bug 350590. Please figure out the best fix of the two patches (or take both).
Flags: blocking-firefox2?
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → Firefox 2
Version: unspecified → 2.0 Branch
Comment 10•18 years ago
|
||
(In reply to comment #9)
> This is a DUPE of the new bug 350590. Please figure out the best fix of the two
> patches (or take both).
Ignore me. I was looking at this screenshot twice (thinking it was for the other bug, too). :(
Comment 11•18 years ago
|
||
*** Bug 350794 has been marked as a duplicate of this bug. ***
Comment 12•18 years ago
|
||
*** Bug 350853 has been marked as a duplicate of this bug. ***
Comment 13•18 years ago
|
||
not a blocker, would take patch (someone poke me in 4-5 hours and I'll take a look)
Flags: blocking-firefox2? → blocking-firefox2-
Comment 14•18 years ago
|
||
Uh, this so totally does block.
Flags: blocking-firefox2- → blocking-firefox2+
Whiteboard: [patch-r?] → [Fx2 theme change]
Assignee | ||
Updated•18 years ago
|
Whiteboard: [Fx2 theme change] → [patch-r?][Fx2 theme change]
Comment 15•18 years ago
|
||
*** Bug 351161 has been marked as a duplicate of this bug. ***
Comment 16•18 years ago
|
||
*** Bug 351187 has been marked as a duplicate of this bug. ***
Comment 17•18 years ago
|
||
Comment on attachment 233248 [details] [diff] [review]
make sure disabled styles take precedence (winstripe)
r+a=me, straightforward belt-and-suspenders patch
Attachment #233248 -
Flags: review?(mconnor)
Attachment #233248 -
Flags: review+
Attachment #233248 -
Flags: approval1.8.1+
Comment 18•18 years ago
|
||
Comment on attachment 233280 [details] [diff] [review]
make sure disabled styles take precedence (pinstripe)
r+a=me, thanks Adam!
Attachment #233280 -
Flags: review?(mconnor)
Attachment #233280 -
Flags: review+
Attachment #233280 -
Flags: approval1.8.1+
Updated•18 years ago
|
Whiteboard: [patch-r?][Fx2 theme change] → [Fx2 theme change][checkin needed]
Assignee | ||
Comment 19•18 years ago
|
||
mozilla/browser/themes/pinstripe/browser/browser.css 1.11.4.40
mozilla/browser/themes/winstripe/browser/browser.css 1.17.2.52
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [Fx2 theme change][checkin needed] → [Fx2 theme change]
Comment 20•18 years ago
|
||
*** Bug 351257 has been marked as a duplicate of this bug. ***
Comment 21•18 years ago
|
||
I would appreciate it if someone would verify this is fixed on Mac for all icon sizes and combinations. This involves adding all the icons to the toolbar and clicking on then in their inactive state. (Note that not all icons will have an inactive state; e.g. the bookmarks button.)
Keywords: verifyme
Comment 22•18 years ago
|
||
In reply to comment #5: there is an alternative to both putting !important on every [disabled=true] pseudo-class and putting :not([disabled="true"] everywhere :active is used.
With every use of [disabled=true], pair it with a [disabled=true]:hover:active line:
#any-button[disabled=true]:hover:active,
#any-button[disabled=true] { etc. }
Using the !important marker in a default theme means trouble when users try to modify their browsers with userChrome.css files.
Comment 23•18 years ago
|
||
FYI the inactive back and forward button in Help window still exhibits this problem. Should a new bug be logged for it or should it be tracked in this bug?
Assignee | ||
Comment 24•18 years ago
|
||
(In reply to comment #22)
> Using the !important marker in a default theme means trouble when users try to
> modify their browsers with userChrome.css files.
You're right - could you file a new bug for this, and attach a patch if possible?
(In reply to comment #23)
> FYI the inactive back and forward button in Help window still exhibits this
> problem. Should a new bug be logged for it or should it be tracked in this bug?
New bug, please.
Assignee | ||
Comment 25•18 years ago
|
||
(In reply to comment #24)
> (In reply to comment #22)
> > Using the !important marker in a default theme means trouble when users try to
> > modify their browsers with userChrome.css files.
>
> You're right - could you file a new bug for this, and attach a patch if
> possible?
I'll fix this here. Mano and I have concluded that using Mano's suggestion from comment 5 is the best choice.
> (In reply to comment #23)
> > FYI the inactive back and forward button in Help window still exhibits this
> > problem. Should a new bug be logged for it or should it be tracked in this bug?
>
> New bug, please.
This was filed as bug 351518.
Assignee | ||
Comment 26•18 years ago
|
||
(In reply to comment #25)
> (In reply to comment #24)
> > (In reply to comment #22)
> > > Using the !important marker in a default theme means trouble when users try to
> > > modify their browsers with userChrome.css files.
> >
> > You're right - could you file a new bug for this, and attach a patch if
> > possible?
>
> I'll fix this here. Mano and I have concluded that using Mano's suggestion from
> comment 5 is the best choice.
On second thought, I'll fix it in bug 348319.
No longer depends on: 351855
Assignee | ||
Comment 27•18 years ago
|
||
(In reply to comment #26)
> On second thought, I'll fix it in bug 348319.
I meant bug 351855, of course.
You need to log in
before you can comment on or make changes to this bug.
Description
•