Closed
Bug 348436
Opened 18 years ago
Closed 18 years ago
Extensions are not able to provide toolbar buttons with an acceptable look [Fx 2.0]
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
WORKSFORME
Firefox 2
People
(Reporter: bugs, Unassigned)
References
Details
(Whiteboard: [Fx2 theme change])
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
I haven't looked into the details of the previous theme checkins, but
with Fx20061108 (Win) it is not possible anymore for an extension to provide
a toolbarbutton which more or less will fit into different themes.
I have tried several extension: all buttons are aligned horribly.
No margins.
In 20061108 I found entries in browser.css like this:
=====================================================
#reload-button {
-moz-image-region: rect(0px 96px 24px 72px);
margin: 0 5px !important;
}
=====================================================
In Fx 1.5/1.0 there was no margin specified for each single
button, allowing extensions to provide a generic button fitting
more or less with different themes.
This is not possible anymore.
Okay, this wasn't working well with a lot themes, but it was at least
a possibility to give the user a button without totally destroying
the look of a toolbar.
Is there a way to provide a toolbarbutton within an extension without
breaking "downwards-compatibility" to Fx 1.5?
The old "system" of hoping the button will fit was bad enough,
but I think that now it is nearly impossible for an extension author
to provide an "acceptable" solution for "all".
Tested with Mouse Gestures 1.5, Button Pack 0.8.5.5, Autohide 1.1.2 and
some others. -> horrible button placement on nav-toolbar.
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1•18 years ago
|
||
Toolbar buttons should really have a standard level of padding and/or margin set and applied on an overall class with any minor adjustments for specific buttons on those.
This is something that should be looked at before Firefox 2 since otherwise as shown in attachment 233373 [details] this will make a lot of extensions look out of place.
Comment 2•18 years ago
|
||
This is related to bug 348442.
Updated•18 years ago
|
Version: unspecified → 2.0 Branch
Comment 3•18 years ago
|
||
We want to preserve extension compatibility as easily as possible for extensions, this is one of the reasons we maintained API stability on the 1.8 branch. We should definitely go back to the old way.
Flags: blocking-firefox2? → blocking-firefox2+
Whiteboard: [Fx2 theme change]
Target Milestone: --- → Firefox 2
Updated•18 years ago
|
QA Contact: extension.manager → toolbars
Comment 4•18 years ago
|
||
May I suggest that toolbar buttons that don't have css specifying otherwise be displayed at a reduced opacity (eg 80%) simulating the desaturated effect of the new theme, and hover would be full opacity. Although this doesn't quite solve the click feedback issue. Maybe default can be eg 80% opacity hover can be 90% and click can be 100%? Or inactive could double as click (probably less desirable) as clicking on the new icons makes them dark and very close to grey.
Works for me now.
This was fixed with the fix for bug 347470?
Checkin:
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=all&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-08-15+22%3A00&maxdate=2006-08-15+23%3A00&cvsroot=%2Fcvsroot
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → WORKSFORME
Updated•18 years ago
|
Flags: blocking-firefox2+
You need to log in
before you can comment on or make changes to this bug.
Description
•