User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6 It is currently extremely difficult (and slow) for extensions to add or control columns in the mail window. Reproducible: Always Expected Results: A native interface should exist allowing extensions to add and modify columns in the mail window.

I am currently working on this - via the SoC program.

This basically implements a number of files that can be accessed via javascript allowing an extension to easily add column handlers. See (patched) nsIMsgDBView.idl:338 for more information.

Added support for: 1. isString() 2. colHandler is now passed into GetCollationKey and GetLongField - this stops it being looked up once per email.

This small patch adds an id to the treecols tag in mail/base/messenger.xul, allowing easy appending of columns to the previous columns. The previous patches are basically useless without this.

Previous patch missed the changes to the mail/ directory (commandglue.js), rendering them quite unusable. This patch includes: 1. commandglue properly handles custom columns 2. messenger.xul has the extra id required to allow for easy column appending 3. Fixed crashes (reference counters) and linking errors (dbienvenu)

re-assigning to Oren - I'm going to start landing parts of this, sr=me...

Is this feature really TB-specific or should the bug be recategorized as Core?

this is the patch as checked in - I made some tweaks to the previous patch: 1. Cleaned up some braces 2. Got rid of one of the overloaded GetLongField/GetCollationKey methods, and used a default nsIMsgCustomColumnHandler = nsnull instead. 3. Added a license header to the new nsIMsgCustomColumnHandler.idl 4. Fixed a windows compile error - windows doesn't like variables defined in the cases of switch statements, w/o surrounding {}

This broke all columns :( Something wrong in check-in?

I just did a clobber build and all the columns work fine for me. What system are you on? And are you running any other type of patch? Small note: the checked in patch misses the small update to messenger.xul which allows easy addition of columns. Not sure if I am missing some way of adding columns or not though...

Sorry, after full rebuild it seems to work.

fix checked into trunk and branch. Thanks, Oren!

(In reply to comment #13) > fix checked into trunk and branch. Thanks, Oren! > is it possible to get the change to messenger.xul checked in as well? Without it attaching columns to the existing set is problematic...