Closed
Bug 348689
Opened 18 years ago
Closed 18 years ago
Keep dialog message inside resources/content instead its generating in c++
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
Details
(Keywords: fixed1.8.0.8, fixed1.8.1.1)
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
I guess we should keep dialog message inside resources/content instead its generating in c++. The follow up changes will be easier for message dialog and the approach is more vivid.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #234666 -
Flags: review?(doronr)
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•18 years ago
|
||
Comment on attachment 234666 [details] [diff] [review]
first try
>+ char* b64 =
>+ PL_Base64Encode(NS_ConvertUTF16toUTF8(docString).get(), 0, nsnull);
>+ if (!b64)
>+ return NS_ERROR_FAILURE;
>+
>+ nsCAutoString b64String;
>+ b64String.AppendLiteral("data:application/vnd.mozilla.xul+xml;base64,");
>+ b64String.Append(b64);
>+ PR_Free(b64);
>+
>+ CopyUTF8toUTF16(b64String, messageURL);
>
You really need this? No other way to load a url?
Attachment #234666 -
Flags: review?(doronr) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
I added background color for html document to approximate look of message to dialog.
Attachment #234666 -
Attachment is obsolete: true
Attachment #235937 -
Flags: review?(Olli.Pettay)
|
|
Assignee | |
Comment 4•18 years ago
|
||
Sorry, I forgot to add new file.
Attachment #235937 -
Attachment is obsolete: true
Attachment #235938 -
Flags: review?(Olli.Pettay)
Attachment #235937 -
Flags: review?(Olli.Pettay)
|
||
Comment 5•18 years ago
|
||
Comment on attachment 235938 [details] [diff] [review]
patch2
> NS_ENSURE_SUCCESS(rv, rv);
>+ htmlEl->SetAttribute(NS_LITERAL_STRING("style"),
>+ NS_LITERAL_STRING("background-color: -moz-Dialog;"));
Missing 2 spaces.
Otherwise looks good. r=me
Attachment #235938 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Comment 6•18 years ago
|
||
checked in by smaug for me.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
checked into 1.8 branch on 2006/11/21
Keywords: fixed1.8.1.1
Whiteboard: xf-to-branch
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•