Closed
Bug 348691
Opened 18 years ago
Closed 18 years ago
[FIX] Speed up nsStaticCaseInsensitiveNameTable::Lookup(nsAString) some more
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Keywords: perf)
Attachments
(2 files)
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
I keep running into this in profiles of CSS stuff.
|
Assignee | |
Comment 1•18 years ago
|
||
The other option I considered was to just have two separate tables with different ops, but both storing nsAFlatCStrings. I don't think that's much of a win in either complexity or speed, and does take more memory.
Attachment #233720 -
Flags: superreview?(dbaron)
Attachment #233720 -
Flags: review?(dbaron)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 233720 [details] [diff] [review] Like so r+sr=dbaron
Attachment #233720 -
Flags: superreview?(dbaron)
Attachment #233720 -
Flags: superreview+
Attachment #233720 -
Flags: review?(dbaron)
Attachment #233720 -
Flags: review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Comment 4•18 years ago
|
||
http://lxr.mozilla.org/mozilla/source/xpcom/ds/nsStaticNameTable.cpp In function ‘const void* nameTableGetKey(PLDHashTable*, PLDHashEntryHdr*)’: http://lxr.mozilla.org/mozilla/source/xpcom/ds/nsStaticNameTable.cpp#83 warning: ‘entry’ is used uninitialized in this function
|
|
Assignee | |
Comment 5•18 years ago
|
||
Yikes. I've gone ahead and checked this in pending review.
Attachment #248776 -
Flags: superreview?(dbaron)
Attachment #248776 -
Flags: review?(dbaron)
|
|
||
Updated•18 years ago
|
Attachment #248776 -
Flags: superreview?(dbaron)
Attachment #248776 -
Flags: superreview+
Attachment #248776 -
Flags: review?(dbaron)
Attachment #248776 -
Flags: review+
You need to log in
before you can comment on or make changes to this bug.
Description
•