Closed
Bug 348756
Opened 18 years ago
Closed 18 years ago
CVS copy nsNativeAppSupportOS2.h to Toolkit
Categories
(mozilla.org :: CVS: Copy, task)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mozilla, Assigned: justdave)
References
Details
Attachments
(2 files)
To be able to build SeaMonkey's suiterunner on OS/2 and to make Toolkit apps independent of nsNativeAppSupportOS2.h from xpfe/bootstrap/ we need to copy that file to the toolkit/xre/ directory.
Reporter | ||
Comment 1•18 years ago
|
||
I believe this is the format to make the copy possible, in this case it's just one line.
Comment 2•18 years ago
|
||
why is windows the only platform that moved their H file here?
Reporter | ||
Comment 3•18 years ago
|
||
I think it's the other way around, OS/2 was just forgotten. Probably because it continued to build as LOCAL_INCLUDEs still points to xpfe/bootstrap/. nsNativeAppSupportBase.h and nsNativeAppSupportWin.h were moved, nsNativeAppSupportOS2.h is the only .h file not copied.
Assignee | ||
Updated•18 years ago
|
Whiteboard: waiting for sr=
Reporter | ||
Comment 4•18 years ago
|
||
mkaply, if I convinced you can you please state this as sr+ for justdave or if not tell me what else we should do?
benjamin, if you know a reason why we should not copy nsNativeAppSupportOS2.h from xpfe to toolkit, please speak up, too.
Comment 5•18 years ago
|
||
yea, sr, looks good to me. We shouldn't be depending on xpfe code in toolkit.
Assignee | ||
Updated•18 years ago
|
Assignee: nobody → justdave
QA Contact: cvs-moves → justin
Assignee | ||
Updated•18 years ago
|
Whiteboard: waiting for sr=
Assignee | ||
Comment 6•18 years ago
|
||
Assignee | ||
Comment 7•18 years ago
|
||
Done.
It'll be your responsibility to cvs delete it from the old location.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•18 years ago
|
||
Thanks, justdave.
I guess the original file will be removed when xpfe/ or xpfe/bootstrap/ gets removed, so I will leave it there for the moment.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•