Closed Bug 348756 Opened 18 years ago Closed 18 years ago

CVS copy nsNativeAppSupportOS2.h to Toolkit

Categories

(mozilla.org :: CVS: Copy, task)

x86
OS/2
task
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mozilla, Assigned: justdave)

References

Details

Attachments

(2 files)

To be able to build SeaMonkey's suiterunner on OS/2 and to make Toolkit apps independent of nsNativeAppSupportOS2.h from xpfe/bootstrap/ we need to copy that file to the toolkit/xre/ directory.
Attached file copy "list" (deleted) —
I believe this is the format to make the copy possible, in this case it's just one line.
why is windows the only platform that moved their H file here?
I think it's the other way around, OS/2 was just forgotten. Probably because it continued to build as LOCAL_INCLUDEs still points to xpfe/bootstrap/. nsNativeAppSupportBase.h and nsNativeAppSupportWin.h were moved, nsNativeAppSupportOS2.h is the only .h file not copied.
Whiteboard: waiting for sr=
mkaply, if I convinced you can you please state this as sr+ for justdave or if not tell me what else we should do? benjamin, if you know a reason why we should not copy nsNativeAppSupportOS2.h from xpfe to toolkit, please speak up, too.
yea, sr, looks good to me. We shouldn't be depending on xpfe code in toolkit.
Assignee: nobody → justdave
QA Contact: cvs-moves → justin
Whiteboard: waiting for sr=
Attached file copy transcript (deleted) —
Done. It'll be your responsibility to cvs delete it from the old location.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Thanks, justdave. I guess the original file will be removed when xpfe/ or xpfe/bootstrap/ gets removed, so I will leave it there for the moment.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: