Closed
Bug 348911
Opened 18 years ago
Closed 18 years ago
Spacing between toolbar icons regression
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
VERIFIED
FIXED
Firefox 2 beta2
People
(Reporter: stevee, Assigned: mwu)
References
Details
(Keywords: regression, verified1.8.1)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
beltzner
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
See attached file. The spacing between the forward/back/reload/stop icons used to be equal and looked good on windows. Now they are not equal, look a bit strange, and take up unnecesasry space.
Reporter | ||
Comment 1•18 years ago
|
||
Comment 2•18 years ago
|
||
It is a regression between 1.8.1b1_2006081514 and 1.8.1b1_2006081606.
Reporter | ||
Comment 3•18 years ago
|
||
Regression range from comment 2
http://tinderbox.mozilla.org/bonsai/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=MOZILLA_1_8_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-08-15+14%3A00%3A00&maxdate=2006-08-16+07%3A00%3A00&cvsroot=%2Fcvsroot
Bug 347470 or bug 348607 perhaps?
Assignee | ||
Comment 4•18 years ago
|
||
Opps. I screwed up unbitrotting my patch before getting it checked in. Gavin's patch should fix this RSN. (bug 347416)
Comment 5•18 years ago
|
||
(In reply to comment #4)
> Gavin's patch should fix this RSN. (bug 347416)
I think this bug should be fixed for B2, and I'm not sure Gavin's bug will make that (the milestone is just Fx2). Nominating for B2. Michael, if you know how to fix this bitrot-bustage in an isolated way, consider posting a patch here so we can take it regardless of bug 347416...
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2 beta2
Assignee | ||
Comment 6•18 years ago
|
||
Assignee: nobody → michael.wu
Status: NEW → ASSIGNED
Assignee | ||
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Comment 7•18 years ago
|
||
Comment on attachment 234182 [details] [diff] [review]
Fix bitrot fix from bug 347470
a=beltzner on behalf of drivers, please land on MOZILLA_1_8_BRANCH and mark fixed1.8.1
Attachment #234182 -
Flags: review+
Attachment #234182 -
Flags: approval1.8.1+
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.1
Reporter | ||
Updated•18 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•18 years ago
|
Keywords: fixed1.8.1 → verified1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•