Closed
Bug 348984
Opened 18 years ago
Closed 18 years ago
'All Tabs' Menu Button misaligned with tabs on the Tabstrip
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: ronin.achilles, Assigned: moco)
References
Details
(Keywords: fixed1.8.1, polish, Whiteboard: [Fx2 theme change])
Attachments
(3 files, 1 obsolete file)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b1) Gecko/20060816 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b1) Gecko/20060816 BonEcho/2.0b1
The 'All Tabs' menu button seems to be misaligned with the tabs i.e. it seems to be lower than the tabs by 1 pixel or so. As a result, when hovered/clicked, the bottom of the 'All Tabs' button overflows beyond the tabstrip bottom border.
Reproducible: Always
Reporter | ||
Comment 1•18 years ago
|
||
I would also suggest that the chevron be "centered" over the scrollbar chevron if at all possible. That would look much better.
~B
Comment 3•18 years ago
|
||
This Screenshot shows the problem even better.
Comment 4•18 years ago
|
||
I don't see this anymore with todays build.
Reporter | ||
Comment 5•18 years ago
|
||
(In reply to comment #4)
> I don't see this anymore with todays build.
>
I still see this problem with 0818 build when there is 'No Overflow'. During overflow, the AllTabs menu along with the right scroll button align themselves to the tabs properly.
Hence the problem still needs to be fixed when in 'no overflow' state.
There are other problems with the AllTabs menu button when in overflow state though, as mentioned in the following bugs that I filed today:
https://bugzilla.mozilla.org/show_bug.cgi?id=349286
https://bugzilla.mozilla.org/show_bug.cgi?id=349287
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Keywords: polish
Whiteboard: [Fx2 theme change]
Target Milestone: --- → Firefox 2
Comment 7•18 years ago
|
||
Confirming. I'm still seeing this in the 8/20 branch build.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 9•18 years ago
|
||
While you're doing this, it's also misaligned in pinstripe ...
Comment 10•18 years ago
|
||
*** Bug 348950 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 11•18 years ago
|
||
Comment on attachment 234401 [details]
screenshot
this screen shot from arpad has since been fixed (by michael wu.) the other screen shot (and the original bug) is still valid.
Attachment #234401 -
Attachment is obsolete: true
Assignee | ||
Comment 12•18 years ago
|
||
mac has a slightly different misalignment, but it is still misaligned.
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 13•18 years ago
|
||
Assignee | ||
Comment 14•18 years ago
|
||
changes to mozilla/toolkit on the MOZILLA_1_8_BRANCH on 8-26-06 have fixed the all tabs button alignment for winstripe. (I'll attach a screen shot)
pinstripe still needs work.
Whiteboard: [Fx2 theme change] → [Fx2 theme change][winstripe aligned, pinstripe still needs work]
Assignee | ||
Comment 15•18 years ago
|
||
Assignee | ||
Comment 16•18 years ago
|
||
part of the problem with pinstripe, unlike winstripe, is the tab images (http://lxr.mozilla.org/mozilla1.8/source/toolkit/themes/pinstripe/global/tab-left.png, tab-middle.png and tab-right.png) have a px transparent row at the top.
the new images from jay (see bug #350139) do not have this problem, so I think this bug should be fixable by:
setting the height of the scrollbuttons and all tabs button elements to be the same height as the tabs (22px), an setting the margin-bottom to be the same as the tabs (3px).
Assignee | ||
Comment 17•18 years ago
|
||
fixed with changes for bug #350139.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [Fx2 theme change][winstripe aligned, pinstripe still needs work] → [Fx2 theme change]
Version: unspecified → 2.0 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•