Closed
Bug 349255
Opened 18 years ago
Closed 9 years ago
[reflow branch] Horizontal scrollbar on annevankesteren blog
Categories
(Core :: Layout, defect, P2)
Core
Layout
Tracking
()
RESOLVED
DUPLICATE
of bug 478834
People
(Reporter: martijn.martijn, Assigned: dbaron)
References
()
Details
(Keywords: regression, testcase, Whiteboard: [float pref width][dbaron-1.9:RwCr])
Attachments
(2 files, 1 obsolete file)
I get a horizontal scrollbar on the annevankesteren blog with the reflow branch, which should not happen.
Reporter | ||
Comment 1•18 years ago
|
||
Comment 2•18 years ago
|
||
So the problem is that block-level replaced elements can end up next to floats, but nsBlockFrame::GetPrefWidth does a Break() on any block line without considering floats. We probably need to modify one or the other...
Assignee | ||
Comment 3•18 years ago
|
||
For what it's worth -- what the intrinsic width here should be is questionable. But there's definitely a bug here in the reflow code for replaced blocks (in general) -- we should clear them past floats when they don't fit next to the floats.
Assignee | ||
Updated•18 years ago
|
Whiteboard: [float pref width]
Assignee | ||
Updated•18 years ago
|
Blocks: reflow-refactor
Updated•18 years ago
|
Flags: blocking1.9?
Assignee | ||
Updated•18 years ago
|
Flags: blocking1.9? → blocking1.9+
Assignee | ||
Updated•17 years ago
|
Whiteboard: [float pref width] → [float pref width][dbaron-1.9:RwCr]
Updated•17 years ago
|
Keywords: regression
Priority: -- → P3
Assignee | ||
Comment 4•17 years ago
|
||
The clearing past floats in comment 3 would also fix the image at the top right of http://www.nytimes.com/2007/11/26/opinion/26krugman.html?pagewanted=print from overflowing at narrow window widths.
Assignee | ||
Comment 6•17 years ago
|
||
Fixed by checkin of bug 134706.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•17 years ago
|
Flags: in-testsuite?
Comment 7•16 years ago
|
||
Bug 437766 seems to be a duplicate. For some reason the scrollbar is still visible here; I tried builds before and after the fix.
Comment 8•16 years ago
|
||
The testcase no longer reproduces the bug, but it's still visible on Anne's site. (I'm on Linux with RC2.)
Updated•16 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•16 years ago
|
||
This testcase still reproduces the bug for me. However, I am not sure if it's really a bug, as Konqueror also displays a horizontal scrollbar.
Attachment #234517 -
Attachment is obsolete: true
Assignee | ||
Comment 10•16 years ago
|
||
I'd guess that the problem there would be that nsBlockFrame::BlockCanIntersectFloats is somehow returning true for the submit input when it should really be returning false.
Assignee | ||
Comment 11•16 years ago
|
||
Actually, it seems like the problem is that ApplyTopMargin is false in nsBlockFrame::ReflowBlockFrame, so we don't do the clearing.
Comment 13•16 years ago
|
||
a bit reduced and generalized
Updated•16 years ago
|
Flags: blocking1.9.1?
Flags: blocking1.9-
Flags: blocking1.9+
Comment 14•16 years ago
|
||
Not going to block 1.9.1, but a P2 wanted.
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
Priority: P3 → P2
Comment 15•15 years ago
|
||
Another example in the wild is http://www.allpcdrivers.com/
Comment 16•11 years ago
|
||
Still a problem on Nightly 27. Works correctly on Chrome 29 and IE10.
Assignee | ||
Comment 17•9 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 17 years ago → 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•