Closed Bug 349318 Opened 18 years ago Closed 18 years ago

"Live Bookmarks" hard-coded in subscribe.xhtml

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: marcoos, Assigned: marcoos)

References

(
URL
)

Details

(Keywords: fixed1.8.1, late-l10n)

Attachments

(1 file, 1 obsolete file)

Patch (for the 1.8 branch)
(deleted), patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review
The "Live Bookmarks" string is hard-coded in subscribe.xhtml and thus is not localizable.
Attached patch Patch (for the 1.8 branch) (obsolete) (deleted) — — Splinter Review
Patch.
Attachment #234584 - Flags: review?
Attachment #234584 - Flags: approval1.8.1?
Attached patch Patch (for the 1.8 branch) (deleted) — — Splinter Review
Patch.
Attachment #234585 - Flags: review?
Attachment #234585 - Flags: approval1.8.1?
Comment on attachment 234584 [details] [diff] [review] Patch (for the 1.8 branch) Sorry, due to a connection problem this patch was submitted twice.
Attachment #234584 - Attachment is obsolete: true
Attachment #234584 - Flags: review?
Attachment #234584 - Flags: approval1.8.1?
Flags: blocking-firefox2?
Keywords: late-l10n
Attachment #234585 - Flags: review? → review?(mconnor)
Setting target milestone to beta2 as that's the milestone for l10n. Leaving this up to drivers, the l10n impact is minor, but there.
Target Milestone: --- → Firefox 2 beta2
Hardware: PC → All
Version: unspecified → 2.0 Branch
Comment on attachment 234585 [details] [diff] [review] Patch (for the 1.8 branch) Good catch, thanks!
Attachment #234585 - Flags: review?(mconnor)
Attachment #234585 - Flags: review+
Attachment #234585 - Flags: approval1.8.1?
Attachment #234585 - Flags: approval1.8.1+
Assignee: nobody → marek.stepien
Status: NEW → ASSIGNED
Whiteboard: [checkin needed] [checkin needed (1.8 branch)]
I hope this is all of them!
Flags: blocking-firefox2? → blocking-firefox2+
Fixed on branch, thanks for catching this! Trunk checkin will done as part of the combo patch for bug 346009.
Blocks: 346009
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed] [checkin needed (1.8 branch)]
v.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: