Closed
Bug 349409
Opened 18 years ago
Closed 18 years ago
Make suiterunner use *stripe's global/ files
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: stefanh, Assigned: stefanh)
References
Details
Attachments
(1 file)
(deleted),
patch
|
kairo
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
It seems that we're first adding the stripe's files to classic.jar and then overwriting them at a later stage with files from classic/global/*
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #234664 -
Flags: review?(kairo)
Assignee | ||
Updated•18 years ago
|
OS: Mac OS X 10.3 → All
Comment 2•18 years ago
|
||
Comment on attachment 234664 [details] [diff] [review]
Don't add files from classic/global
As long as we're not needing those files from anywhere else in the tree or for the files still blocking bug 336874 this looks good to me. I still have to test before marking r+ but I think it might even be good to break stuff in suiterunner where we rely on theming not available in *stripe global, so we see what we still need to change.
Comment 3•18 years ago
|
||
Comment on attachment 234664 [details] [diff] [review]
Don't add files from classic/global
OK, seems to work.
Now we just should make native theming more native so that e.g. groupboxes look like they should even in GTK2 or WinClassic, not only in WinXP Luna :)
Attachment #234664 -
Flags: review?(kairo) → review+
Assignee | ||
Updated•18 years ago
|
Attachment #234664 -
Flags: superreview?(neil)
Assignee | ||
Updated•18 years ago
|
Blocks: suiterunner
Assignee | ||
Comment 4•18 years ago
|
||
Neil, can you take a look at this, please?
Updated•18 years ago
|
Attachment #234664 -
Flags: superreview?(neil) → superreview+
Updated•18 years ago
|
Assignee: general → stefanh
Assignee | ||
Comment 5•18 years ago
|
||
Checking in jar.mn;
/cvsroot/mozilla/themes/classic/jar.mn,v <-- jar.mn
new revision: 1.161; previous revision: 1.160
done
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey1.5alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•