Closed
Bug 349906
Opened 18 years ago
Closed 18 years ago
Don't depend on PangoXft
Categories
(Core Graveyard :: GFX: Gtk, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
(Keywords: fixed1.8.1.8)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jshin1987
:
review+
rbs
:
superreview+
dveditz
:
approval1.8.1.8+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060501 Epiphany/2.14 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060501 Epiphany/2.14 Currently the Pango font backend depends on Gtk+ using the PangoXft backend. Which is wrong for Gtk+ 2.8. Attaching fix. Reproducible: Always
Assignee | ||
Comment 1•18 years ago
|
||
Comment on attachment 235103 [details] [diff] [review] Mentioned patch That code hasn't evolved much since blizzard's initial check-in. I will sr if jshin is happy with the patch. http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/gfx/src/gtk/mozilla-decoder.cpp&rev=HEAD&mark=1.3
Attachment #235103 -
Flags: superreview?(rbs)
Attachment #235103 -
Flags: review?(jshin)
Attachment #235103 -
Flags: review?(jshin) → review?(jshin1987)
Note to self. Undo the debugging #define #undef DEBUG_CUSTOM_ENCODER +#define DEBUG_CUSTOM_ENCODER 1
Assignee | ||
Comment 4•18 years ago
|
||
Removed the debugging statement.
Attachment #235103 -
Attachment is obsolete: true
Attachment #235103 -
Flags: superreview?(rbs)
Attachment #235103 -
Flags: review?(jshin1987)
Attachment #235350 -
Flags: superreview?(rbs)
Attachment #235350 -
Flags: review?(jshin1987)
Updated•18 years ago
|
Assignee: nobody → mozilla
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 5•18 years ago
|
||
Comment on attachment 235350 [details] [diff] [review] Updated patch r=jshin
Attachment #235350 -
Flags: review?(jshin1987) → review+
Comment on attachment 235350 [details] [diff] [review] Updated patch sr=rbs, I will check this in quickly.
Attachment #235350 -
Flags: superreview?(rbs) → superreview+
Checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 8•18 years ago
|
||
(In reply to comment #7) > Checked in. > In bug 338446 we took care that configure(.in) checks for the presence of pangoxft in order to pull it in, as pangoxft automatically pulled by gtk+ 2.8. The only reason was the dependency of gfx/src/gtk/mozilla-decoder.cpp on pangoxft. Now, we could reverse the part of the patch https://bugzilla.mozilla.org/attachment.cgi?id=227071 concerning configure.in (but not gfx/src/gtk/Makefile.in) as pangoxft isn't needed anymore in case using default-toolkit=gtk2. Interestingly, yesterday for the cairo-gtk2 toolkit a patch for bug 334064 was checked in that brings in more pangoxft dependencies.
Comment 9•17 years ago
|
||
Comment on attachment 235350 [details] [diff] [review] Updated patch Branch approval requested for same reasons as: https://bugzilla.mozilla.org/show_bug.cgi?id=349904#c6
Attachment #235350 -
Flags: approval1.8.1.8?
Comment 10•17 years ago
|
||
Comment on attachment 235350 [details] [diff] [review] Updated patch approved for 1.8.1.8, a=dveditz for release-drivers
Attachment #235350 -
Flags: approval1.8.1.8? → approval1.8.1.8+
Comment 11•17 years ago
|
||
Checking in mozilla-decoder.cpp; /cvsroot/mozilla/gfx/src/gtk/Attic/mozilla-decoder.cpp,v <-- mozilla-decoder.c pp new revision: 1.3.20.1; previous revision: 1.3 done Checked into the 1.8.1 branch.
Keywords: fixed1.8.1
Updated•17 years ago
|
Keywords: fixed1.8.1 → fixed1.8.1.8
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•