Closed
Bug 349956
Opened 18 years ago
Closed 18 years ago
Decompiler can't make up its mind for <x/>.@*
Categories
(Core :: JavaScript Engine, defect, P2)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.8.1
People
(Reporter: jruderman, Assigned: brendan)
References
Details
(Keywords: testcase, verified1.8.1)
Attachments
(1 file)
(deleted),
patch
|
shaver
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
> function () { <x/>.@* }
function () { <x/>[@[*]]; }
> function () { <x/>[@[*]]; }
function () { <x/>.@[*]; }
The fact that it takes more than 1 trip through uneval to settle on a final form confuses my fuzzer in bug 349611.
> function () { <x/>.@[*]; }
function () { <x/>[@[*]]; }
The fact that it *never* settles on a final form (bouncing back and forth between two forms) bothers me even more.
These aren't necessarily bugs, but they do interfere with certain methods of testing decompilation.
Assignee | ||
Comment 1•18 years ago
|
||
Need shaver to sub for mrbkap while mrbkap drives back to Rice via L.A.
/be
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #235177 -
Flags: review?(shaver)
Attachment #235177 -
Flags: approval1.8.1?
Assignee | ||
Updated•18 years ago
|
OS: Mac OS X 10.4 → All
Priority: -- → P2
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
Updated•18 years ago
|
Attachment #235177 -
Flags: approval1.8.1?
Comment 2•18 years ago
|
||
Shaver, please renom for 181 assuming this passes your review. Also, be sure to tell us how it feels to be the new mrbkap!
Comment on attachment 235177 [details] [diff] [review]
fix
r=shaver.
I was the old mrbkap before mrbkap was the new mrbkap.
Attachment #235177 -
Flags: review?(shaver)
Attachment #235177 -
Flags: review+
Attachment #235177 -
Flags: approval1.8.1?
Assignee | ||
Comment 4•18 years ago
|
||
Fixed on trunk.
Checking in jsopcode.c;
/cvsroot/mozilla/js/src/jsopcode.c,v <-- jsopcode.c
new revision: 3.146; previous revision: 3.145
done
/be
Comment 5•18 years ago
|
||
Comment on attachment 235177 [details] [diff] [review]
fix
a=beltzner on behalf of the 181drivers
Attachment #235177 -
Flags: approval1.8.1? → approval1.8.1+
Reporter | ||
Comment 7•18 years ago
|
||
That fixed <x/>.@* to not go into a back-and-forth loop, but the back-and-forth loop is still there. I filed bug 350226 for that.
Comment 8•18 years ago
|
||
Checking in regress-349956.js;
/cvsroot/mozilla/js/tests/e4x/Regress/regress-349956.js,v <-- regress-349956.js
initial revision: 1.1
Flags: in-testsuite+
Comment 9•18 years ago
|
||
verified fixed 1.8 20060827 windows/mac*/linux
both 1.8.0.7, 1.8 agree
expected: function () { <x/>.@*; }
actual: function () { <x/>.@*; }
Keywords: fixed1.8.1 → verified1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•