Closed Bug 349956 Opened 18 years ago Closed 18 years ago

Decompiler can't make up its mind for <x/>.@*

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

VERIFIED FIXED
mozilla1.8.1

People

(Reporter: jruderman, Assigned: brendan)

References

Details

(Keywords: testcase, verified1.8.1)

Attachments

(1 file)

> function () { <x/>.@* } function () { <x/>[@[*]]; } > function () { <x/>[@[*]]; } function () { <x/>.@[*]; } The fact that it takes more than 1 trip through uneval to settle on a final form confuses my fuzzer in bug 349611. > function () { <x/>.@[*]; } function () { <x/>[@[*]]; } The fact that it *never* settles on a final form (bouncing back and forth between two forms) bothers me even more. These aren't necessarily bugs, but they do interfere with certain methods of testing decompilation.
Attached patch fix (deleted) — Splinter Review
Need shaver to sub for mrbkap while mrbkap drives back to Rice via L.A. /be
Assignee: general → brendan
Status: NEW → ASSIGNED
Attachment #235177 - Flags: review?(shaver)
Attachment #235177 - Flags: approval1.8.1?
OS: Mac OS X 10.4 → All
Priority: -- → P2
Hardware: Macintosh → All
Target Milestone: --- → mozilla1.8.1
Shaver, please renom for 181 assuming this passes your review. Also, be sure to tell us how it feels to be the new mrbkap!
Comment on attachment 235177 [details] [diff] [review] fix r=shaver. I was the old mrbkap before mrbkap was the new mrbkap.
Attachment #235177 - Flags: review?(shaver)
Attachment #235177 - Flags: review+
Attachment #235177 - Flags: approval1.8.1?
Fixed on trunk. Checking in jsopcode.c; /cvsroot/mozilla/js/src/jsopcode.c,v <-- jsopcode.c new revision: 3.146; previous revision: 3.145 done /be
Blocks: js1.7
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment on attachment 235177 [details] [diff] [review] fix a=beltzner on behalf of the 181drivers
Attachment #235177 - Flags: approval1.8.1? → approval1.8.1+
Fixed on the 1.8 branch. /be
Keywords: fixed1.8.1
That fixed <x/>.@* to not go into a back-and-forth loop, but the back-and-forth loop is still there. I filed bug 350226 for that.
Checking in regress-349956.js; /cvsroot/mozilla/js/tests/e4x/Regress/regress-349956.js,v <-- regress-349956.js initial revision: 1.1
Flags: in-testsuite+
verified fixed 1.8 20060827 windows/mac*/linux both 1.8.0.7, 1.8 agree expected: function () { <x/>.@*; } actual: function () { <x/>.@*; }
verified fixed 1.9 20060827 windows/mac*/linux
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: