Closed
Bug 349970
Opened 18 years ago
Closed 18 years ago
[Mac] Findbar button hover state background images are broken
Categories
(Toolkit :: Find Toolbar, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: philor, Assigned: pamg.bugs)
References
()
Details
(Keywords: fixed1.8.1, Whiteboard: [Fx2 theme change])
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Obligatory screenshot
Because Pinstripe used the bookmark background images to make rounded-rect backgrounds for the find toolbar's Next, Previous, and Highlight buttons, they are now broken with the new images that weren't designed with the findbar in mind - there's a gap between the left edge/icon and the right edge/text.
|
Reporter | |
Updated•18 years ago
|
Flags: blocking-firefox2?
|
|
Reporter | |
Comment 1•18 years ago
|
||
|
||
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
|
||
Updated•18 years ago
|
Assignee: nobody → pamg.bugs
|
Assignee | |
Comment 3•18 years ago
|
||
It's not an image problem, it's a margin on the text label. Compare "Next", "Previous" and "Highlight all" to "Match case" in a recent Mac build. Anyway, here's a CSS fix.
Attachment #235835 -
Flags: review?(mconnor)
Attachment #235835 -
Flags: approval1.8.1?
|
|
||
Updated•18 years ago
|
Whiteboard: [artwork needed]
|
|
||
Comment 4•18 years ago
|
||
Comment on attachment 235835 [details] [diff] [review]
Removes extra margin from labels
r+a=me on this branch theme fix. Thanks again Pam!
Attachment #235835 -
Flags: review?(mconnor)
Attachment #235835 -
Flags: review+
Attachment #235835 -
Flags: approval1.8.1?
Attachment #235835 -
Flags: approval1.8.1+
|
|
||
Updated•18 years ago
|
Whiteboard: [Fx2 theme change][checkin needed (1.8 branch)]
|
|
Assignee | |
Comment 5•18 years ago
|
||
Landing on branch only.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [Fx2 theme change][checkin needed (1.8 branch)] → [Fx2 theme change]
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•