Closed
Bug 350161
Opened 18 years ago
Closed 18 years ago
very difficult the selecting URL text and drag to tab bar for opening
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
DUPLICATE
of bug 138245
People
(Reporter: masayuki, Assigned: masayuki)
References
()
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
See the test case:
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=3292
In the first paragraph, the br elements are on the tail of the line in source code. This is generally style. We can open the url easily by selecting a line and dragging the selection and dropping to tabber.
But in the second paragraph, the br elements are on the head of the line in source code. This is not a generally style, maybe. But some dynamic contents may use this style. In this case we cannot open the url easily by D&D.
I'll create the patch.
Comment 1•18 years ago
|
||
This WFM on:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20060824 Minefield/3.0a1
I can triple-click on any of the URLs in the testcase (including the three on the bottom), and drag them into the URL bar, and the browser navigates as expected.
Assignee | ||
Comment 2•18 years ago
|
||
Hey, Uri, please drop *tab bar* or *tab*.
Comment 3•18 years ago
|
||
(In reply to comment #2)
> Hey, Uri, please drop *tab bar* or *tab*.
>
Sorry - my bad. When dropping to the tab bar (or tab) I do see the problem.
Assignee | ||
Updated•18 years ago
|
Summary: very difficult the selecting URL text and drag to tabber for opening → very difficult the selecting URL text and drag to tab bar for opening
Updated•18 years ago
|
Assignee: masayuki → nobody
Component: General → Tabbed Browser
OS: Windows 2000 → All
QA Contact: general → tabbed.browser
Hardware: PC → All
Assignee | ||
Updated•18 years ago
|
Assignee: nobody → masayuki
Assignee | ||
Comment 4•18 years ago
|
||
This patch trims the space of the URL.
Attachment #235409 -
Flags: review?(neil)
Assignee | ||
Comment 5•18 years ago
|
||
Comment on attachment 235409 [details] [diff] [review]
Patch rv1.0
Oops, sorry. The patch is not for this bug.
Attachment #235409 -
Attachment is obsolete: true
Attachment #235409 -
Flags: review?(neil)
Assignee | ||
Comment 6•18 years ago
|
||
Attachment #235411 -
Flags: review?(neil)
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Comment 7•18 years ago
|
||
(In reply to comment #3)
>When dropping to the tab bar (or tab) I do see the problem.
So should we be selecting the (invisible) trailing space?
We don't select invisible leading space.
Comment 8•18 years ago
|
||
Hmmm... I just realized this is probably a duplicate of bug 138245, although now that this one has a patch, you might want to dupe that one to this one.
See also bug 252441.
Assignee | ||
Comment 9•18 years ago
|
||
right.
dup to bug 138245.
*** This bug has been marked as a duplicate of 138245 ***
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•18 years ago
|
Attachment #235411 -
Flags: review?(neil)
Comment 10•18 years ago
|
||
(In reply to comment #7)
> So should we be selecting the (invisible) trailing space?
> We don't select invisible leading space.
>
That trailing space used to be selectable (and not "invisible") until the recent fix for bug 132561. Now that it's invisible, I guess it shouldn't be selected by triple-click, but I need to think about this a bit more.
Comment 11•18 years ago
|
||
(In reply to comment #10)
>That trailing space used to be selectable (and not "invisible") until the
>recent fix for bug 132561. Now that it's invisible, I guess it shouldn't be
>selected by triple-click, but I need to think about this a bit more.
That's OK, I since decided that it's useful to drop untrimmed URLs.
You need to log in
before you can comment on or make changes to this bug.
Description
•