Closed Bug 350183 Opened 18 years ago Closed 18 years ago

[regression] Back / Forward icons not vertically aligned anymore; too high

Categories

(Firefox :: Toolbars and Customization, defect, P2)

Product:
Firefox
Component:
Toolbars and Customization
Version:
2.0 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2

People

(Reporter: stevee, Assigned: asaf)

References

Details

(Keywords: fixed1.8.1, regression)

Attachments

(3 files)

screenshot showing vertical misalignment
(deleted), image/png
Details
back/forward vertical misalignment with small icons
(deleted), image/png
Details
patch
(deleted), patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b2) Gecko/20060825 BonEcho/2.0b2 ID:2006082504

The back/forward icons are too high up on the toolbar. They used to be vertically centered, but no more. Icons were properly aligned in the 20060824 nightly.

Probably a regression from bug 349148
No longer blocks: 349148
Blocks: 349148

  

  



    
    

    
  


  

  

  


Flags: blocking-firefox2?

    
  
Component: General → Toolbars
QA Contact: general → toolbars

    
  
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firefox 2

    
    

    
  
I see it says Assigned, but to whom?

  

  


Assignee: nobody → bugs.mano
Status: ASSIGNED → NEW

    
  
Status: NEW → ASSIGNED

    
  
OS: Windows 2000 → All
Hardware: PC → All

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (deleted)
        — 
          — Splinter Review
      

    


  

  

  



        Attachment #235408 -
        Flags: review?(mconnor)
Flags: blocking-firefox2? → blocking-firefox2+

    
    

    
  
Comment on attachment 235408 [details] [diff] [review]
patch

r+a=me on this theme fix

  

  



        Attachment #235408 -
        Flags: review?(mconnor)

        Attachment #235408 -
        Flags: review+

        Attachment #235408 -
        Flags: approval1.8.1+

    
    

    
  
1.8 branch:
mozilla/browser/themes/pinstripe/browser/browser.css 1.11.4.32
mozilla/browser/themes/pinstripe/browser/browser.xml 1.3.12.3
mozilla/browser/themes/winstripe/browser/browser.css  1.17.2.43
mozilla/browser/themes/winstripe/browser/browser.xml 1.4.8.4

  

  


Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED

    
    

    
  
*** Bug 350254 has been marked as a duplicate of this bug. ***

  

  



    
    

    
  
*** Bug 350305 has been marked as a duplicate of this bug. ***

  

  



          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: