Closed
Bug 350282
Opened 18 years ago
Closed 18 years ago
New tabs are overlaying the toolbar customization sheet
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: asaf, Assigned: asaf)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
(deleted),
patch
|
mconnor
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Since there's no reliable way to disable every single way to open a tab while the sheet is open, we need to workaround the underlying bug.
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
|
|
Assignee | |
Comment 1•18 years ago
|
||
This is suboptimal since the entire action is visibile, but i's better than nothing.
I _think_ that removing the iframe (i.e. inling the content) which is what I plan to do on trunk will address this issue for real.
Attachment #235551 -
Flags: review?(mconnor)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 235551 [details] [diff] [review]
workaround
hmm, this is ok, assuming this is an edge case, but I'd like a better solution for the trunk impl :)
Attachment #235551 -
Flags: review?(mconnor) → review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #235551 -
Flags: approval1.8.1?
|
||
Updated•18 years ago
|
Whiteboard: [land on trunk]
|
|
Assignee | |
Comment 3•18 years ago
|
||
mozilla/browser/base/content/browser.js 1.696
mozilla/browser/base/content/customizeToolbarSheet.xul 1.2
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [land on trunk]
|
|
||
Comment 4•18 years ago
|
||
Comment on attachment 235551 [details] [diff] [review]
workaround
a=schrep/beltnzer for drivers.
Attachment #235551 -
Flags: approval1.8.1? → approval1.8.1+
|
|
||
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
|
|
Assignee | |
Comment 5•18 years ago
|
||
I can only land this once bug 350129 is approved and landed...
|
|
Assignee | |
Comment 6•18 years ago
|
||
Landed on the 1.8 branch, see bug 350129 comment 9.
Keywords: fixed1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•